diff --git a/CHANGELOG.md b/CHANGELOG.md index da3adbc..01be416 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -2,6 +2,8 @@ ## [Unreleased] +🐛 — Fix bug in retry_before_notification logic when success + ## 0.7.2 Date: 2025-01-24 diff --git a/argos/server/alerting.py b/argos/server/alerting.py index 81b3a3d..d533ed4 100644 --- a/argos/server/alerting.py +++ b/argos/server/alerting.py @@ -36,7 +36,7 @@ def need_alert( # create notification of success immediately if ( status == "success" - and task.contiguous_failures >= task.retry_before_notification + and task.contiguous_failures >= task.retry_before_notification + 1 ): send_notif = True task.contiguous_failures = 0 @@ -56,7 +56,7 @@ def need_alert( task.contiguous_failures = task.retry_before_notification # Severity has not changed, but there has been enough failures # to create a notification - elif task.retry_before_notification + 1 == task.contiguous_failures: + elif task.contiguous_failures == task.retry_before_notification + 1: send_notif = True return send_notif