diff --git a/CHANGELOG.md b/CHANGELOG.md index c95cc59..6d92cb2 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -3,6 +3,8 @@ ## [Unreleased] - 🩹 — Avoid warning from MySQL only alembic instructions +- 🩹 — Check before adding/removing ip_version_enum + ## 0.7.0 diff --git a/argos/server/migrations/versions/64f73a79b7d8_add_ip_version_to_checks.py b/argos/server/migrations/versions/64f73a79b7d8_add_ip_version_to_checks.py index 0cd752a..cde4c77 100644 --- a/argos/server/migrations/versions/64f73a79b7d8_add_ip_version_to_checks.py +++ b/argos/server/migrations/versions/64f73a79b7d8_add_ip_version_to_checks.py @@ -21,7 +21,7 @@ depends_on: Union[str, Sequence[str], None] = None def upgrade() -> None: enum = ENUM("4", "6", name="ip_version_enum", create_type=False) - enum.create(op.get_bind(), checkfirst=False) + enum.create(op.get_bind(), checkfirst=True) with op.batch_alter_table("tasks", schema=None) as batch_op: batch_op.add_column( sa.Column("ip_version", enum, server_default="4", nullable=False) @@ -31,4 +31,4 @@ def upgrade() -> None: def downgrade() -> None: with op.batch_alter_table("tasks", schema=None) as batch_op: batch_op.drop_column("ip_version") - ENUM(name="ip_version_enum").drop(op.get_bind(), checkfirst=False) + ENUM(name="ip_version_enum").drop(op.get_bind(), checkfirst=True)