From 0b83e2a235f9b2ae43acedb4035a8a96e5e4781c Mon Sep 17 00:00:00 2001 From: aurelienshz Date: Fri, 8 Sep 2023 14:54:12 +0200 Subject: [PATCH] Refactor both incoming and former deliveries to avoid lambda hell --- copanier/models.py | 10 ++++------ 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/copanier/models.py b/copanier/models.py index 93f3363..e69e961 100644 --- a/copanier/models.py +++ b/copanier/models.py @@ -503,15 +503,13 @@ class Delivery(PersistedBase): @classmethod def incoming(cls): - return sorted( - [d for d in cls.all() if d.is_foreseen], key=lambda d: d.order_before - ) + incoming_deliveries = [d for d in cls.all() if d.is_foreseen] + return sorted(incoming_deliveries, key=lambda d: d.order_before) @classmethod def former(cls): - return sorted( - [d for d in cls.all() if not d.is_foreseen], key=lambda d: d.from_date, reverse=True - ) + former_deliveries = [d for d in cls.all() if not d.is_foreseen] + return sorted(former_deliveries, key=lambda d: d.from_date, reverse=True) @property def path(self):