From a6a504d0cac637e33c29e74f360cb3e902daf824 Mon Sep 17 00:00:00 2001
From: Yohan Boniface <yb@enix.org>
Date: Wed, 17 Apr 2019 21:31:53 +0200
Subject: [PATCH] Skip products without orders in order form

---
 copanier/__init__.py             | 2 +-
 copanier/reports.py              | 2 ++
 copanier/templates/delivery.html | 2 +-
 tests/test_reports.py            | 3 +--
 4 files changed, 5 insertions(+), 4 deletions(-)

diff --git a/copanier/__init__.py b/copanier/__init__.py
index 63db98c..c4b7afc 100644
--- a/copanier/__init__.py
+++ b/copanier/__init__.py
@@ -359,7 +359,7 @@ async def import_commande(request, response, id):
     response.redirect = f"/livraison/{delivery.id}"
 
 
-@app.route("/livraison/{id}/rapport.xlsx", methods=["GET"])
+@app.route("/livraison/{id}/bon-de-commande.xlsx", methods=["GET"])
 async def xls_report(request, response, id):
     delivery = Delivery.load(id)
     response.xlsx(reports.summary(delivery))
diff --git a/copanier/reports.py b/copanier/reports.py
index 7bb959e..89232b0 100644
--- a/copanier/reports.py
+++ b/copanier/reports.py
@@ -21,6 +21,8 @@ def summary(delivery):
     ws.append(headers)
     for product in delivery.products:
         wanted = delivery.product_wanted(product)
+        if not wanted:
+            continue
         ws.append(
             [
                 product.ref,
diff --git a/copanier/templates/delivery.html b/copanier/templates/delivery.html
index fc5b48e..b3e3c7d 100644
--- a/copanier/templates/delivery.html
+++ b/copanier/templates/delivery.html
@@ -60,7 +60,7 @@
 <hr>
 <ul class="toolbox">
     <li>
-        <a href="/livraison/{{ delivery.id }}/rapport.xlsx"><i class="icon-ribbon"></i> Bon de commande</a>
+        <a href="/livraison/{{ delivery.id }}/bon-de-commande.xlsx"><i class="icon-ribbon"></i> Bon de commande</a>
     </li>
     <li>
         <a href="/livraison/{{ delivery.id }}/rapport-complet.xlsx"><i class="icon-grid"></i> Rapport complet</a>
diff --git a/tests/test_reports.py b/tests/test_reports.py
index 833ff7d..5790d3b 100644
--- a/tests/test_reports.py
+++ b/tests/test_reports.py
@@ -6,7 +6,7 @@ from copanier import reports
 from copanier.models import Order, Product, ProductOrder
 
 
-def test_export_products(client, delivery):
+def test_summary_report(client, delivery):
     delivery.products[0].packing = 6
     delivery.products.append(
         Product(ref="456", name="yaourt", price="3.5", packing=4, unit="pot 125ml")
@@ -21,6 +21,5 @@ def test_export_products(client, delivery):
         ("ref", "produit", "prix unitaire", "quantité commandée", "unité", "total"),
         ("123", "Lait", 1.5, 1, None, 1.5),
         ("456", "yaourt (pot 125ml)", 3.5, 4, "pot 125ml", 14),
-        ("789", "fromage", 9.2, 0, None, 0),
         (None, None, None, None, "Total", 15.5),
     ]