almet/dangerzone
1
0
Fork 0
mirror of https://github.com/freedomofpress/dangerzone.git synced 2025-04-28 18:02:38 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions 11

tests: Tokenize CLI arguments

Browse source 
Pass tokenized arguments (i.e., arguments as lists of strings) to CLI
invocations, else Click will attempt to tokenize them internally. The
problem with leaving tokenization to Click is that it uses
`shlex.split()`, which is Unix-oriented, and may miss some cases in
Windows.
This commit is contained in:
Alex Pyrgiotis 2022-10-19 18:06:41 +03:00
parent 6b7797639c
commit 51d4fb04c8
No known key found for this signature in database
GPG key ID: B6C15EBA0357C9AA
1 changed files with 5 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

10
tests/test_cli.py
View file

@ -150,24 +150,24 @@ class TestCliBasic(TestCli):
class TestCliConversion(TestCliBasic): class TestCliConversion(TestCliBasic):
def test_invalid_lang(self): def test_invalid_lang(self):
result = self.run_cli(f"{self.sample_doc} --ocr-lang piglatin") result = self.run_cli([self.sample_doc, "--ocr-lang", "piglatin"])
result.assert_failure() result.assert_failure()
@for_each_doc @for_each_doc
def test_formats(self, doc): def test_formats(self, doc):
result = self.run_cli(f'"{doc}"') result = self.run_cli(str(doc))
result.assert_success() result.assert_success()
def test_output_filename(self): def test_output_filename(self):
temp_dir = tempfile.mkdtemp(prefix="dangerzone-") temp_dir = tempfile.mkdtemp(prefix="dangerzone-")
result = self.run_cli( result = self.run_cli(
f"{self.sample_doc} --output-filename {temp_dir}/safe.pdf" [self.sample_doc, "--output-filename", f"{temp_dir}/safe.pdf"]
) )
result.assert_success() result.assert_success()
def test_output_filename_new_dir(self): def test_output_filename_new_dir(self):
result = self.run_cli( result = self.run_cli(
f"{self.sample_doc} --output-filename fake-directory/my-output.pdf" [self.sample_doc, "--output-filename", "fake-directory/my-output.pdf"]
) )
result.assert_failure() result.assert_failure()
@ -176,7 +176,7 @@ class TestCliConversion(TestCliBasic):
result.assert_failure() result.assert_failure()
def test_lang_eng(self): def test_lang_eng(self):
result = self.run_cli(f'"{self.sample_doc}" --ocr-lang eng') result = self.run_cli([self.sample_doc, "--ocr-lang", "eng"])
result.assert_success() result.assert_success()
@pytest.mark.parametrize( @pytest.mark.parametrize(