From 541fe7f382003af152375093f30e582a138a770c Mon Sep 17 00:00:00 2001 From: deeplow Date: Mon, 13 Feb 2023 14:28:55 +0000 Subject: [PATCH] Container: ignore non-progress pdftoppm output pdftoppm raises Syntax issues and Errors on a variety of documents. But it still produces usable results despite the failures. From the user's perspective it's best to have a document even if imperfect than having none at all. For this reason, we ignore non-relevant output. --- container/dangerzone.py | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/container/dangerzone.py b/container/dangerzone.py index df9342c..7285482 100644 --- a/container/dangerzone.py +++ b/container/dangerzone.py @@ -305,7 +305,10 @@ class DangerzoneConverter: num_pages = int(num_pages_str) page = int(page_str) except ValueError as e: - raise RuntimeError("Conversion from PDF to PPM failed") from e + # Ignore all non-progress related output, since pdftoppm sends + # everything to stderr and thus, errors can't be distinguished + # easily. We rely instead on the exit code. + return percentage_per_page = 45.0 / num_pages self.percentage += percentage_per_page