From 65776d8c0506535c20f74f4375193287e1e8a78b Mon Sep 17 00:00:00 2001 From: Alex Pyrgiotis Date: Tue, 14 May 2024 11:54:02 +0300 Subject: [PATCH] Quote command in installation instructions Zsh users that attempt to run the following command in our Ubuntu/Debian installation instructions: echo deb [signed-by=/etc/apt/keyrings/fpf-apt-tools-archive-keyring.gpg] \ https://packages.freedom.press/apt-tools-prod ${VERSION_CODENAME?} main \ | sudo tee /etc/apt/sources.list.d/fpf-apt-tools.list encounter the following error: zsh: no matches found: [signed-by=/etc/apt/keyrings/fpf-apt-tools-archive-keyring.gpg] Quote this command to ensure compatibility with other shells, and update our CI checks. Fixes #805 --- .github/workflows/check_repos.yml | 4 ++-- INSTALL.md | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/.github/workflows/check_repos.yml b/.github/workflows/check_repos.yml index 067ca8e..d4ab1d8 100644 --- a/.github/workflows/check_repos.yml +++ b/.github/workflows/check_repos.yml @@ -58,8 +58,8 @@ jobs: - name: Add packages.freedom.press to our APT sources run: | . /etc/os-release - echo deb [signed-by=/etc/apt/keyrings/fpf-apt-tools-archive-keyring.gpg] \ - https://packages.freedom.press/apt-tools-prod ${VERSION_CODENAME?} main \ + echo "deb [signed-by=/etc/apt/keyrings/fpf-apt-tools-archive-keyring.gpg] \ + https://packages.freedom.press/apt-tools-prod ${VERSION_CODENAME?} main" \ | tee /etc/apt/sources.list.d/fpf-apt-tools.list - name: Install Dangerzone diff --git a/INSTALL.md b/INSTALL.md index e90bbf7..817c1d1 100644 --- a/INSTALL.md +++ b/INSTALL.md @@ -94,8 +94,8 @@ Add the URL of the repo in your APT sources: ```sh . /etc/os-release -echo deb [signed-by=/etc/apt/keyrings/fpf-apt-tools-archive-keyring.gpg] \ - https://packages.freedom.press/apt-tools-prod ${VERSION_CODENAME?} main \ +echo "deb [signed-by=/etc/apt/keyrings/fpf-apt-tools-archive-keyring.gpg] \ + https://packages.freedom.press/apt-tools-prod ${VERSION_CODENAME?} main" \ | sudo tee /etc/apt/sources.list.d/fpf-apt-tools.list ```