From 7d0c96eaacc66ef59548e05f595b35b51de531dc Mon Sep 17 00:00:00 2001 From: "David J. Meier" Date: Sat, 28 Mar 2020 13:52:34 -0500 Subject: [PATCH] Fix for tasks.py The `container.py` file has two functions that are incorrectly referenced in `tasks.py`. These are `document_to_pixels` and `pixels_to_pdf`. Renaming the args in the `tasks.py` file to appropriately reference those functions. Without these fixes the software crashes with an error of: `Error: No such command "document-to-pixels"` and `Error: No such command "pixels_to_pdf"`. The is_docker_ready function passes an invalid argument to exec_dangerzone_container. The passed argument contains a dash instead of an underscore. This creates the logic situation wherein the UI states that Docker is not installed on Linux derivatives and also issues a Failed to start docker service command line error. --- dangerzone/tasks.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/dangerzone/tasks.py b/dangerzone/tasks.py index 1398203..245f4fc 100644 --- a/dangerzone/tasks.py +++ b/dangerzone/tasks.py @@ -72,7 +72,7 @@ class ConvertToPixels(TaskBase): def run(self): self.update_label.emit("Converting document to pixels") args = [ - "document-to-pixels", + "document_to_pixels", "--document-filename", self.common.document_filename, "--pixel-dir", @@ -173,7 +173,7 @@ class ConvertToPDF(TaskBase): ] args = [ - "pixels-to-pdf", + "pixels_to_pdf", "--pixel-dir", self.common.pixel_dir.name, "--safe-dir",