From 93a06d72f036cd81aa09bfa9a8aa4993dfc3e2d2 Mon Sep 17 00:00:00 2001
From: Alex Pyrgiotis <alex.p@freedom.press>
Date: Wed, 15 Feb 2023 13:55:15 +0200
Subject: [PATCH] Allow users to disable timeouts

Allow users to disable timeouts via the CLI, with the
`--disable-timeouts` argument. By default, the timeouts are always
enabled.

This option applies both to the CLI version of Dangerzone, and the GUI
one. For the latter, the user must start the GUI from their CLI (i.e.,
`dangerzone --disable-timeouts ...`)
---
 container/dangerzone.py                    |  3 +++
 dangerzone/cli.py                          |  9 ++++++++-
 dangerzone/gui/__init__.py                 | 12 ++++++++++--
 dangerzone/isolation_provider/container.py |  9 +++++++--
 4 files changed, 28 insertions(+), 5 deletions(-)

diff --git a/container/dangerzone.py b/container/dangerzone.py
index f3608cf..df9342c 100644
--- a/container/dangerzone.py
+++ b/container/dangerzone.py
@@ -121,6 +121,9 @@ class DangerzoneConverter:
         * Documents with lots of pages, but small file size.
         * Single images with large file size.
         """
+        if not int(os.environ.get("ENABLE_TIMEOUTS", 1)):
+            return None
+
         # Do not have timeouts lower than 10 seconds, if the file size is small, since
         # we need to take into account the program's startup time as well.
         timeout = max(TIMEOUT_PER_MB * size, 10)
diff --git a/dangerzone/cli.py b/dangerzone/cli.py
index d96c7a8..6092693 100644
--- a/dangerzone/cli.py
+++ b/dangerzone/cli.py
@@ -36,6 +36,12 @@ def print_header(s: str) -> None:
 @click.option(
     "--unsafe-dummy-conversion", "dummy_conversion", flag_value=True, hidden=True
 )
+@click.option(
+    "--enable-timeouts / --disable-timeouts",
+    default=True,
+    show_default=True,
+    help="Enable/Disable timeouts during document conversion",
+)
 @click.argument(
     "filenames",
     required=True,
@@ -48,6 +54,7 @@ def print_header(s: str) -> None:
 def cli_main(
     output_filename: Optional[str],
     ocr_lang: Optional[str],
+    enable_timeouts: bool,
     filenames: List[str],
     archive: bool,
     dummy_conversion: bool,
@@ -57,7 +64,7 @@ def cli_main(
     if getattr(sys, "dangerzone_dev", False) and dummy_conversion:
         dangerzone = DangerzoneCore(Dummy())
     else:
-        dangerzone = DangerzoneCore(Container())
+        dangerzone = DangerzoneCore(Container(enable_timeouts=enable_timeouts))
 
     display_banner()
     if len(filenames) == 1 and output_filename:
diff --git a/dangerzone/gui/__init__.py b/dangerzone/gui/__init__.py
index ce8c3a8..ca7dee5 100644
--- a/dangerzone/gui/__init__.py
+++ b/dangerzone/gui/__init__.py
@@ -62,6 +62,12 @@ class Application(QtWidgets.QApplication):
 @click.option(
     "--unsafe-dummy-conversion", "dummy_conversion", flag_value=True, hidden=True
 )
+@click.option(
+    "--enable-timeouts / --disable-timeouts",
+    default=True,
+    show_default=True,
+    help="Enable/Disable timeouts during document conversion",
+)
 @click.argument(
     "filenames",
     required=False,
@@ -71,7 +77,9 @@ class Application(QtWidgets.QApplication):
 )
 @click.version_option(version=get_version(), message="%(version)s")
 @errors.handle_document_errors
-def gui_main(dummy_conversion: bool, filenames: Optional[List[str]]) -> bool:
+def gui_main(
+    dummy_conversion: bool, filenames: Optional[List[str]], enable_timeouts: bool
+) -> bool:
     setup_logging()
 
     if platform.system() == "Darwin":
@@ -93,7 +101,7 @@ def gui_main(dummy_conversion: bool, filenames: Optional[List[str]]) -> bool:
         dummy = Dummy()
         dangerzone = DangerzoneGui(app, isolation_provider=dummy)
     else:
-        container = Container()
+        container = Container(enable_timeouts=enable_timeouts)
         dangerzone = DangerzoneGui(app, isolation_provider=container)
 
     # Allow Ctrl-C to smoothly quit the program instead of throwing an exception
diff --git a/dangerzone/isolation_provider/container.py b/dangerzone/isolation_provider/container.py
index 212debd..59c6ee3 100644
--- a/dangerzone/isolation_provider/container.py
+++ b/dangerzone/isolation_provider/container.py
@@ -36,8 +36,9 @@ class Container(IsolationProvider):
     # Name of the dangerzone container
     CONTAINER_NAME = "dangerzone.rocks/dangerzone"
 
-    def __init__(self) -> None:
-        pass
+    def __init__(self, enable_timeouts: bool) -> None:
+        self.enable_timeouts = 1 if enable_timeouts else 0
+        super().__init__()
 
     @staticmethod
     def get_runtime_name() -> str:
@@ -247,6 +248,8 @@ class Container(IsolationProvider):
             f"{document.input_filename}:/tmp/input_file",
             "-v",
             f"{pixel_dir}:/dangerzone",
+            "-e",
+            f"ENABLE_TIMEOUTS={self.enable_timeouts}",
         ]
         ret = self.exec_container(document, command, extra_args, stdout_callback)
         if ret != 0:
@@ -269,6 +272,8 @@ class Container(IsolationProvider):
                 f"OCR={ocr}",
                 "-e",
                 f"OCR_LANGUAGE={ocr_lang}",
+                "-e",
+                f"ENABLE_TIMEOUTS={self.enable_timeouts}",
             ]
             ret = self.exec_container(document, command, extra_args, stdout_callback)
             if ret != 0: