From b5c09e51d8fbc3f74e5af78193f51b055ab7ebc4 Mon Sep 17 00:00:00 2001 From: Alex Pyrgiotis Date: Mon, 31 Mar 2025 19:29:58 +0300 Subject: [PATCH] Update minimum Docker Desktop version Update the minimum Docker Desktop version prior to the 0.9.0 release. The new version should also fix a recent Docker bug, whereby the container stdout was truncated, and caused our conversions to fail. Fixes #1101 --- CHANGELOG.md | 1 + dangerzone/isolation_provider/container.py | 4 ++-- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 5ed25af..a26c1f2 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -31,6 +31,7 @@ since 0.4.1, and this project adheres to [Semantic Versioning](https://semver.or - Fix our Debian Trixie installation instructions using Sequoia PGP ([#1052](https://github.com/freedomofpress/dangerzone/issues/1052)) - Fix the way multiprocessing works on macOS ([#873](https://github.com/freedomofpress/dangerzone/issues/873)) +- Update minimum Docker Desktop version to fix an stdout truncation issue ([#1101](https://github.com/freedomofpress/dangerzone/issues/1101)) ### Removed diff --git a/dangerzone/isolation_provider/container.py b/dangerzone/isolation_provider/container.py index ed810f8..4976732 100644 --- a/dangerzone/isolation_provider/container.py +++ b/dangerzone/isolation_provider/container.py @@ -13,8 +13,8 @@ from .base import IsolationProvider, terminate_process_group TIMEOUT_KILL = 5 # Timeout in seconds until the kill command returns. MINIMUM_DOCKER_DESKTOP = { - "Darwin": "4.36.0", - "Windows": "4.36.0", + "Darwin": "4.40.0", + "Windows": "4.40.0", } # Define startupinfo for subprocesses