From e0b3c5b599c0a75e0d9c68e8fa70c0fbfad47716 Mon Sep 17 00:00:00 2001 From: deeplow Date: Wed, 17 Aug 2022 09:34:31 +0100 Subject: [PATCH] resolve naming conflict: QWidget.update() QWidget.update() is already a built-in Qt method [1]. This method was unintentionally being overriden. Renamed it to update_progress to fix it. [1]: https://doc.qt.io/qtforpython-5/PySide2/QtWidgets/QWidget.html#PySide2.QtWidgets.PySide2.QtWidgets.QWidget.update --- dangerzone/gui/main_window.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/dangerzone/gui/main_window.py b/dangerzone/gui/main_window.py index 75ab60c..7b61945 100644 --- a/dangerzone/gui/main_window.py +++ b/dangerzone/gui/main_window.py @@ -607,11 +607,11 @@ class ConvertWidget(QtWidgets.QWidget): def start(self) -> None: self.convert_t = ConvertThread(self.global_common, self.common) - self.convert_t.update.connect(self.update) + self.convert_t.update.connect(self.update_progress) self.convert_t.finished.connect(self.all_done) self.convert_t.start() - def update(self, error: bool, text: str, percentage: int) -> None: + def update_progress(self, error: bool, text: str, percentage: int) -> None: if error: self.error = True self.error_image.show()