From f3806b96af9c5aaa3be3285a004366613a6cd3e8 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Alexis=20M=C3=A9taireau?= Date: Sat, 9 Nov 2024 21:42:05 +0100 Subject: [PATCH] Reapply "Disable gVisor's DirectFS feature."" This reverts commit 68f8338d2032dd90b17e9b7c5d400fb532c5f20f. Fixes #982 --- CHANGELOG.md | 5 +++++ dangerzone/gvisor_wrapper/entrypoint.py | 3 +++ 2 files changed, 8 insertions(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index bade81d..ccdf8ef 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -7,6 +7,11 @@ since 0.4.1, and this project adheres to [Semantic Versioning](https://semver.or ## [Unreleased](https://github.com/freedomofpress/dangerzone/compare/v0.8.0...HEAD) +### Added + +- Disable gVisor's DirectFS feature ([#226](https://github.com/freedomofpress/dangerzone/issues/226)). + Thanks [EtiennePerot](https://github.com/EtiennePerot) for the contribution. + ## [0.8.0](https://github.com/freedomofpress/dangerzone/compare/v0.8.0...0.7.1) ### Added diff --git a/dangerzone/gvisor_wrapper/entrypoint.py b/dangerzone/gvisor_wrapper/entrypoint.py index f9941ed..8d09eb2 100755 --- a/dangerzone/gvisor_wrapper/entrypoint.py +++ b/dangerzone/gvisor_wrapper/entrypoint.py @@ -142,6 +142,9 @@ runsc_argv = [ "--rootless=true", "--network=none", "--root=/home/dangerzone/.containers", + # Disable DirectFS for to make the seccomp filter even stricter, + # at some performance cost. + "--directfs=false", ] if os.environ.get("RUNSC_DEBUG"): runsc_argv += ["--debug=true", "--alsologtostderr=true"]