5 commits

Author	SHA1	Message	Date
Alexis Métaireau	55bd68ce1e	Mock the settings rather than monkeypatching external modules	2025-03-26 12:22:52 +01:00
Alexis Métaireau	162e528f97	Decouple the Settings class from DangerzoneCore ... No real reason to pass the whole object where what we really need is just the location of the configuration folder.	2025-03-26 12:22:52 +01:00
Alexis Métaireau	5aa4863b52	chore(imports): remove useless imports ... As detected by [ruff](https://github.com/astral-sh/ruff) Related to #254, although it doesn't provide the command to lint the codebase itself.	2024-06-05 14:19:30 +02:00
Naglis Jonaitis	5b6cc861d8	Don't use pytest-mock mocker.patch as context manager ... Quote from `pytest-mock` docs [1]: > The purpose of this plugin is to make the use of context managers and > function decorators for mocking unnecessary, so it will emit a warning > when used as such. Thus using it as a context manager currently produces a warning during test runs in CI which is extra noise that could make new (possibly more important) warnings harder to spot. [1]: https://pytest-mock.readthedocs.io/en/latest/usage.html#usage-as-context-manager	2024-05-08 15:40:14 +03:00
deeplow	9bb1993e77	Create tests/test_settings.py with extra coverage ... Previously settings was implicitly tested on tests/gui/test_updater.py. However this was concerned with updater-related tests only, which incidentally covered almost all of settings.py. However, a few tests were missing. This commit increases the test coverage, but also tests additional test conditions. The goal is to help us increase the test coverage of the previous scenario, which tested for the persistence of user data (settings). This way we can drop the requirement to test this on linux hosts, which is slightly harder (more cumbersome) to do.	2024-04-01 18:18:41 +03:00