mirror of
https://github.com/freedomofpress/dangerzone.git
synced 2025-04-28 18:02:38 +02:00
![]() Remove timeouts due to several reasons: 1. Lost purpose: after implementing the containers page streaming the only subprocess we have left is LibreOffice. So don't have such a big risk of commands hanging (the original reason for timeouts). 2. Little benefit: predicting execution time is generically unsolvable computer science problem. Ultimately we were guessing an arbitrary time based on the number of pages and the document size. As a guess we made it pretty lax (30s per page or MB). A document hanging for this long will probably lead to user frustration in any case and the user may be compelled to abort the conversion. 3. Technical Challenges with non-blocking timeout: there have been several technical challenges in keeping timeouts that we've made effort to accommodate. A significant one was having to do non-blocking read to ensure we could timeout when reading conversion stream (and then used here) Fixes #687 |
||
---|---|---|
.. | ||
gui | ||
isolation_provider | ||
test_docs | ||
test_docs_compressed | ||
test_docs_external | ||
test_docs_large@0068ffcb67 | ||
__init__.py | ||
conftest.py | ||
test_cli.py | ||
test_document.py | ||
test_large_set.py | ||
test_ocr.py | ||
test_util.py |