From 292397aff7993d103a5bf0250f42a62c263ab301 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Alexis=20M=C3=A9taireau?= <alexis@vieuxsinge.com>
Date: Sun, 5 Aug 2018 19:09:08 +0200
Subject: [PATCH] Simplify a JS function.

---
 ihatemoney/static/js/ihatemoney.js | 25 +++++++------------------
 ihatemoney/templates/forms.html    |  2 +-
 2 files changed, 8 insertions(+), 19 deletions(-)

diff --git a/ihatemoney/static/js/ihatemoney.js b/ihatemoney/static/js/ihatemoney.js
index 24e82b78..c240dc1a 100644
--- a/ihatemoney/static/js/ihatemoney.js
+++ b/ihatemoney/static/js/ihatemoney.js
@@ -1,18 +1,7 @@
- // Add scripts to select all or non of the checkboxes in the add_bill form
-function selectall()
-    {
-        var els = document.getElementsByName('payed_for');
-        for(var i =0;i<els.length;i++)
-        {
-            els[i].checked=true;
-        }
-    }
-function selectnone()
-    {
-        var els = document.getElementsByName('payed_for');
-        for(var i =0;i<els.length;i++)
-        {
-            els[i].checked=false;
-        }
-    }
-
+ // Utility to select all or none of the checkboxes in the add_bill form.
+function selectCheckboxes(value){
+  var els = document.getElementsByName('payed_for');
+  for(var i = 0; i < els.length; i++){
+    els[i].checked = value;
+  }
+}
diff --git a/ihatemoney/templates/forms.html b/ihatemoney/templates/forms.html
index 63d1c3c7..6d99dfd1 100644
--- a/ihatemoney/templates/forms.html
+++ b/ihatemoney/templates/forms.html
@@ -100,7 +100,7 @@
         <label class="col-3" for="payed_for">{{ _("For whom?") }}</label>
         <div class="controls col-9">
             <ul id="payed_for" class="inputs-list">
-                <p><a href="#" id="selectall" onclick="selectall()">{{ _("Select all") }}</a> | <a href="#" id="selectnone" onclick="selectnone()">{{_("Select none")}}</a></p>
+                <p><a href="#" id="selectall" onclick="selectCheckboxes(true)">{{ _("Select all") }}</a> | <a href="#" id="selectnone" onclick="selectCheckboxes(false)">{{_("Select none")}}</a></p>
             {% for key, value, checked in form.payed_for.iter_choices() %}
                 <p class="form-check"><label for="payed_for-{{key}}" class="form-check-label"><input name="payed_for" type="checkbox" {% if checked %}checked{% endif %} class="form-check-input" value="{{key}}" id="payed_for-{{key}}"/><span>{{value}}</span></label></p>
             {% endfor %}