almet/ihatemoney
1
0
Fork 0
mirror of https://github.com/spiral-project/ihatemoney.git synced 2025-04-28 17:32:38 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions

Fix the tests for user reactivation

Browse source
This commit is contained in:
Alexis Métaireau 2025-01-05 16:05:33 +01:00
parent 0d7308fccb
commit 43260d0dc4
No known key found for this signature in database
GPG key ID: 1C21B876828E5FF2
1 changed files with 19 additions and 24 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

39
ihatemoney/tests/budget_test.py
View file

@ -452,8 +452,8 @@ class TestBudget(IhatemoneyTestCase):
result = self.client.get("/raclette/add") result = self.client.get("/raclette/add")
assert "jeanne" not in result.data.decode("utf-8") assert "jeanne" not in result.data.decode("utf-8")
# adding him again should reactivate him # it should be possible to reactivate him
self.client.post("/raclette/members/add", data={"name": "jeanne"}) self.client.post(f"/raclette/members/{jeanne_id}/reactivate")
assert len(self.get_project("raclette").active_members) == 2 assert len(self.get_project("raclette").active_members) == 2
# adding an user with the same name as another user from a different # adding an user with the same name as another user from a different
@ -1847,32 +1847,28 @@ class TestBudget(IhatemoneyTestCase):
assert "No bills" in resp.data.decode("utf-8") assert "No bills" in resp.data.decode("utf-8")
def test_add_duplicate_user(self): def test_add_duplicate_user(self):
"""
''' Adding a user with the same name as a deactivated user with 0 balance
Adding a user with same name as a deactivated user with 0 balance and no associated bills should succeed
and no associated bills should success """
'''
self.post_project("raclette") self.post_project("raclette")
self.login("raclette") self.login("raclette")
# adds a member to this project # adds a member to this project and delete it right after.
self.client.post("/raclette/members/add", data={"name": "zorglub"}) self.client.post("/raclette/members/add", data={"name": "zorglub"})
# delete user using POST method
self.client.post("/raclette/members/1/delete") self.client.post("/raclette/members/1/delete")
self.assertEqual(len(self.get_project("raclette").active_members), 0) assert len(self.get_project("raclette").active_members) == 0
self.assertEqual(len(self.get_project("raclette").members), 0) assert len(self.get_project("raclette").members) == 0
# try to add this deleted user should be successful
response = self.client.get("/raclette/members/add", data={"name": "zorglub"})
self.assertEqual(len(self.get_project("raclette").members), 1)
self.assertEqual(response.status_code, 200)
# try to add this deleted user should be successful
response = self.client.post("/raclette/members/add", data={"name": "zorglub"})
assert len(self.get_project("raclette").members) == 1
def test_add_duplicate_user_with_balance(self): def test_add_duplicate_user_with_balance(self):
''' """
Adding a user with same name as a deactivated user with non-zero balance Adding a user with same name as a deactivated user with non-zero balance
and associated bills should fail and associated bills should fail
''' """
self.post_project("raclette") self.post_project("raclette")
# add two participants # add two participants
@ -1898,14 +1894,13 @@ class TestBudget(IhatemoneyTestCase):
"/raclette/members/%s/delete" % self.get_project("raclette").members[-1].id "/raclette/members/%s/delete" % self.get_project("raclette").members[-1].id
) )
self.assertEqual(len(self.get_project("raclette").members), 2) assert len(self.get_project("raclette").members) == 2
self.client.post("/raclette/members/add", data={"name": "Bob"}) self.client.post("/raclette/members/add", data={"name": "Bob"})
# adding a user with the same name should fail # adding a user with the same name should fail
self.assertEqual(len(self.get_project("raclette").members), 2) assert len(self.get_project("raclette").members) == 2
# The only active_member is Alice, this means adding a new Bob failed # The only active_member is Alice, this means adding a new Bob failed
self.assertEqual(len(self.get_project("raclette").active_members), 1) assert len(self.get_project("raclette").active_members) == 1
def test_session_projects_migration_to_list(self): def test_session_projects_migration_to_list(self):
"""In https://github.com/spiral-project/ihatemoney/pull/1082, session["projects"] """In https://github.com/spiral-project/ihatemoney/pull/1082, session["projects"]