almet/ihatemoney
1
0
Fork 0
mirror of https://github.com/spiral-project/ihatemoney.git synced 2025-05-06 13:01:50 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions

Add test to verify unrelated-change owers bug without web requests

Browse source
This commit is contained in:
Andrew Dickinson 2020-04-17 14:45:19 -04:00
parent 5cc8b5a68c
commit 825386ce99
1 changed files with 34 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

37
ihatemoney/tests/tests.py
View file

@ -17,7 +17,7 @@ from flask_testing import TestCase
from ihatemoney.run import create_app, db, load_configuration from ihatemoney.run import create_app, db, load_configuration
from ihatemoney.manage import GenerateConfig, GeneratePasswordHash, DeleteProject from ihatemoney.manage import GenerateConfig, GeneratePasswordHash, DeleteProject
from ihatemoney import models from ihatemoney import models, history
from ihatemoney.versioning import LoggingMode from ihatemoney.versioning import LoggingMode
from ihatemoney import utils from ihatemoney import utils
from sqlalchemy import orm from sqlalchemy import orm
@ -78,7 +78,7 @@ class BaseTestCase(TestCase):
class IhatemoneyTestCase(BaseTestCase): class IhatemoneyTestCase(BaseTestCase):
SQLALCHEMY_DATABASE_URI = "sqlite://" SQLALCHEMY_DATABASE_URI = "sqlite:////tmp/ihatemoneytest.db"
TESTING = True TESTING = True
WTF_CSRF_ENABLED = False # Simplifies the tests. WTF_CSRF_ENABLED = False # Simplifies the tests.
@ -2807,7 +2807,7 @@ class HistoryTestCase(IhatemoneyTestCase):
self.assertIn( self.assertIn(
"Bill %s added" % em_surround("25.0 for Bill 1"), resp.data.decode("utf-8") "Bill %s added" % em_surround("25.0 for Bill 1"), resp.data.decode("utf-8")
) )
self.assertEquals( self.assertEqual(
resp.data.decode("utf-8").count( resp.data.decode("utf-8").count(
"Bill %s added" % em_surround("25.0 for Bill 1") "Bill %s added" % em_surround("25.0 for Bill 1")
), ),
@ -2821,6 +2821,37 @@ class HistoryTestCase(IhatemoneyTestCase):
resp.data.decode("utf-8"), resp.data.decode("utf-8"),
) )
def test_double_bill_double_person_edit_second_no_web(self):
u1 = models.Person(project_id="demo", name="User 1")
u2 = models.Person(project_id="demo", name="User 1")
models.db.session.add(u1)
models.db.session.add(u2)
models.db.session.commit()
b1 = models.Bill(what="Bill 1", payer_id=u1.id, owers=[u2], amount=10,)
b2 = models.Bill(what="Bill 2", payer_id=u2.id, owers=[u2], amount=11,)
# This db commit exposes the "spurious owers edit" bug
models.db.session.add(b1)
models.db.session.commit()
models.db.session.add(b2)
models.db.session.commit()
history_list = history.get_history(models.Project.query.get("demo"))
self.assertEqual(len(history_list), 5)
# Change just the amount
b1.amount = 5
models.db.session.commit()
history_list = history.get_history(models.Project.query.get("demo"))
for entry in history_list:
if "prop_changed" in entry:
self.assertNotIn("owers", entry["prop_changed"])
self.assertEqual(len(history_list), 6)
if __name__ == "__main__": if __name__ == "__main__":
unittest.main() unittest.main()