almet/ihatemoney
1
0
Fork 0
mirror of https://github.com/spiral-project/ihatemoney.git synced 2025-05-06 05:01:48 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions

code clarity: exit case on top and two separate loops

Browse source
This commit is contained in:
Glandos 2021-07-05 23:03:10 +02:00
parent f3bc1066c5
commit 9011ca23c6
1 changed files with 18 additions and 15 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

31
ihatemoney/models.py
View file

@ -272,24 +272,26 @@ class Project(db.Model):
return pretty_bills return pretty_bills
def switch_currency(self, new_currency): def switch_currency(self, new_currency):
if new_currency == self.default_currency:
return
# Update converted currency # Update converted currency
if new_currency != self.default_currency:
if (
new_currency == CurrencyConverter.no_currency
and self.has_multiple_currencies()
):
raise ValueError(f"Can't unset currency of project {self.id}")
for bill in self.get_bills_unordered():
if new_currency == CurrencyConverter.no_currency: if new_currency == CurrencyConverter.no_currency:
# Use old currency to flatten all amount before stripping if self.has_multiple_currencies():
bill.converted_amount = CurrencyConverter().exchange_currency( raise ValueError(f"Can't unset currency of project {self.id}")
bill.amount, bill.original_currency, self.default_currency
) for bill in self.get_bills_unordered():
# We are removing the currency, and we already checked that all bills
# had the same currency: it means that we can simply strip the currency
# without converting the amounts. We basically ignore the current default_currency
# Reset converted amount in case it was different from the original amount
bill.converted_amount = bill.amount
# Strip currency # Strip currency
bill.amount = bill.converted_amount
bill.original_currency = CurrencyConverter.no_currency bill.original_currency = CurrencyConverter.no_currency
elif bill.original_currency == CurrencyConverter.no_currency: db.session.add(bill)
else:
for bill in self.get_bills_unordered():
if bill.original_currency == CurrencyConverter.no_currency:
# Bills that were created without currency will be set to the new currency # Bills that were created without currency will be set to the new currency
bill.original_currency = new_currency bill.original_currency = new_currency
bill.converted_amount = bill.amount bill.converted_amount = bill.amount
@ -299,6 +301,7 @@ class Project(db.Model):
bill.amount, bill.original_currency, new_currency bill.amount, bill.original_currency, new_currency
) )
db.session.add(bill) db.session.add(bill)
self.default_currency = new_currency self.default_currency = new_currency
db.session.add(self) db.session.add(self)
db.session.commit() db.session.commit()