almet/ihatemoney
1
0
Fork 0
mirror of https://github.com/spiral-project/ihatemoney.git synced 2025-04-28 17:32:38 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions

tests: unit test assertion fixes (#1203)

Browse source 
`self.assertTrue(200, resp.status_code)` style are always True
and thus are useless. It looks like the original author wanted
`self.assertEqual` there instead.
This commit is contained in:
Éloi Rivard 2023-07-28 17:44:43 +02:00 committed by GitHub
parent 4d3bcf69d3
commit b1d4f34193
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 8 additions and 8 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

16
ihatemoney/tests/api_test.py
View file

@ -94,7 +94,7 @@ class APITestCase(IhatemoneyTestCase):
}, },
) )
self.assertTrue(400, resp.status_code) self.assertEqual(400, resp.status_code)
self.assertEqual( self.assertEqual(
'{"contact_email": ["Invalid email address."]}\n', resp.data.decode("utf-8") '{"contact_email": ["Invalid email address."]}\n', resp.data.decode("utf-8")
) )
@ -102,7 +102,7 @@ class APITestCase(IhatemoneyTestCase):
# create it # create it
with self.app.mail.record_messages() as outbox: with self.app.mail.record_messages() as outbox:
resp = self.api_create("raclette") resp = self.api_create("raclette")
self.assertTrue(201, resp.status_code) self.assertEqual(201, resp.status_code)
# Check that email messages have been sent. # Check that email messages have been sent.
self.assertEqual(len(outbox), 1) self.assertEqual(len(outbox), 1)
@ -111,7 +111,7 @@ class APITestCase(IhatemoneyTestCase):
# create it twice should return a 400 # create it twice should return a 400
resp = self.api_create("raclette") resp = self.api_create("raclette")
self.assertTrue(400, resp.status_code) self.assertEqual(400, resp.status_code)
self.assertIn("id", json.loads(resp.data.decode("utf-8"))) self.assertIn("id", json.loads(resp.data.decode("utf-8")))
# get information about it # get information about it
@ -119,7 +119,7 @@ class APITestCase(IhatemoneyTestCase):
"/api/projects/raclette", headers=self.get_auth("raclette") "/api/projects/raclette", headers=self.get_auth("raclette")
) )
self.assertTrue(200, resp.status_code) self.assertEqual(200, resp.status_code)
expected = { expected = {
"members": [], "members": [],
"name": "raclette", "name": "raclette",
@ -197,7 +197,7 @@ class APITestCase(IhatemoneyTestCase):
# Create project # Create project
resp = self.api_create("raclette") resp = self.api_create("raclette")
self.assertTrue(201, resp.status_code) self.assertEqual(201, resp.status_code)
# Get token # Get token
resp = self.client.get( resp = self.client.get(
@ -577,19 +577,19 @@ class APITestCase(IhatemoneyTestCase):
def test_currencies(self): def test_currencies(self):
# check /currencies for list of supported currencies # check /currencies for list of supported currencies
resp = self.client.get("/api/currencies") resp = self.client.get("/api/currencies")
self.assertTrue(201, resp.status_code) self.assertEqual(200, resp.status_code)
self.assertIn("XXX", json.loads(resp.data.decode("utf-8"))) self.assertIn("XXX", json.loads(resp.data.decode("utf-8")))
# create project with a default currency # create project with a default currency
resp = self.api_create("raclette", default_currency="EUR") resp = self.api_create("raclette", default_currency="EUR")
self.assertTrue(201, resp.status_code) self.assertEqual(201, resp.status_code)
# get information about it # get information about it
resp = self.client.get( resp = self.client.get(
"/api/projects/raclette", headers=self.get_auth("raclette") "/api/projects/raclette", headers=self.get_auth("raclette")
) )
self.assertTrue(200, resp.status_code) self.assertEqual(200, resp.status_code)
expected = { expected = {
"members": [], "members": [],
"name": "raclette", "name": "raclette",