almet/ihatemoney
1
0
Fork 0
mirror of https://github.com/spiral-project/ihatemoney.git synced 2025-05-06 05:01:48 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions

clearer code when switching to another currency

Browse source 
the code has the same effect for the database, but should be
clearer for reviewers ;)
This commit is contained in:
Glandos 2021-07-04 15:46:50 +02:00
parent 8ee59b3509
commit c0796c1ebf
1 changed files with 5 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

9
ihatemoney/models.py
View file

@ -289,14 +289,15 @@ class Project(db.Model):
# Strip currency # Strip currency
bill.amount = bill.converted_amount bill.amount = bill.converted_amount
bill.original_currency = CurrencyConverter.no_currency bill.original_currency = CurrencyConverter.no_currency
elif bill.original_currency == CurrencyConverter.no_currency:
# Bills that were created without currency will be set to the new currency
bill.original_currency = new_currency
bill.converted_amount = bill.amount
else: else:
# Switch to new currency for everyone # Convert amount for others, without touching original_currency
bill.converted_amount = CurrencyConverter().exchange_currency( bill.converted_amount = CurrencyConverter().exchange_currency(
bill.amount, bill.original_currency, new_currency bill.amount, bill.original_currency, new_currency
) )
# Add the currency for bills that were created without currency
if bill.original_currency == CurrencyConverter.no_currency:
bill.original_currency = new_currency
db.session.add(bill) db.session.add(bill)
self.default_currency = new_currency self.default_currency = new_currency
db.session.add(self) db.session.add(self)