pep8ify the tests

This commit is contained in:
Alexis Métaireau 2017-06-28 22:00:35 +02:00
parent ff018bd0c8
commit e70bd029b4

View file

@ -321,11 +321,11 @@ class BudgetTestCase(TestCase):
response = self.app.get("/raclette/members/1/delete") response = self.app.get("/raclette/members/1/delete")
self.assertEqual(response.status_code, 405) self.assertEqual(response.status_code, 405)
#delete user using POST method # delete user using POST method
self.app.post("/raclette/members/1/delete") self.app.post("/raclette/members/1/delete")
self.assertEqual( self.assertEqual(
len(models.Project.query.get("raclette").active_members), 0) len(models.Project.query.get("raclette").active_members), 0)
#try to delete an user already deleted # try to delete an user already deleted
self.app.post("/raclette/members/1/delete") self.app.post("/raclette/members/1/delete")
def test_demo(self): def test_demo(self):
@ -461,7 +461,7 @@ class BudgetTestCase(TestCase):
balance = models.Project.query.get("raclette").balance balance = models.Project.query.get("raclette").balance
self.assertEqual(set(balance.values()), set([19.0, -19.0])) self.assertEqual(set(balance.values()), set([19.0, -19.0]))
#Bill with negative amount # Bill with negative amount
self.app.post("/raclette/add", data={ self.app.post("/raclette/add", data={
'date': '2011-08-12', 'date': '2011-08-12',
'what': 'fromage à raclette', 'what': 'fromage à raclette',
@ -472,7 +472,7 @@ class BudgetTestCase(TestCase):
bill = models.Bill.query.filter(models.Bill.date == '2011-08-12')[0] bill = models.Bill.query.filter(models.Bill.date == '2011-08-12')[0]
self.assertEqual(bill.amount, -25) self.assertEqual(bill.amount, -25)
#add a bill with a comma # add a bill with a comma
self.app.post("/raclette/add", data={ self.app.post("/raclette/add", data={
'date': '2011-08-01', 'date': '2011-08-01',
'what': 'fromage à raclette', 'what': 'fromage à raclette',
@ -528,7 +528,6 @@ class BudgetTestCase(TestCase):
resp = self.app.get("/raclette/") resp = self.app.get("/raclette/")
self.assertNotIn('extra-info', resp.data.decode('utf-8')) self.assertNotIn('extra-info', resp.data.decode('utf-8'))
def test_rounding(self): def test_rounding(self):
self.post_project("raclette") self.post_project("raclette")
@ -568,7 +567,8 @@ class BudgetTestCase(TestCase):
result[models.Project.query.get("raclette").members[1].id] = 0.0 result[models.Project.query.get("raclette").members[1].id] = 0.0
result[models.Project.query.get("raclette").members[2].id] = -8.12 result[models.Project.query.get("raclette").members[2].id] = -8.12
# Since we're using floating point to store currency, we can have some rounding issues that prevent test from working. # Since we're using floating point to store currency, we can have some rounding issues that prevent test from working.
# However, we should obtain the same values as the theorical ones if we round to 2 decimals, like in the UI. # However, we should obtain the same values as the theorical ones if we
# round to 2 decimals, like in the UI.
for key, value in six.iteritems(balance): for key, value in six.iteritems(balance):
self.assertEqual(round(value, 2), result[key]) self.assertEqual(round(value, 2), result[key])
@ -613,7 +613,7 @@ class BudgetTestCase(TestCase):
self.app.post("/raclette/members/add", data={'name': 'alexis'}) self.app.post("/raclette/members/add", data={'name': 'alexis'})
self.app.post("/raclette/members/add", data={'name': 'fred'}) self.app.post("/raclette/members/add", data={'name': 'fred'})
self.app.post("/raclette/members/add", data={'name': 'tata'}) self.app.post("/raclette/members/add", data={'name': 'tata'})
#Add a member with a balance=0 : # Add a member with a balance=0 :
self.app.post("/raclette/members/add", data={'name': 'toto'}) self.app.post("/raclette/members/add", data={'name': 'toto'})
# create bills # create bills
@ -643,10 +643,10 @@ class BudgetTestCase(TestCase):
project = models.Project.query.get('raclette') project = models.Project.query.get('raclette')
transactions = project.get_transactions_to_settle_bill() transactions = project.get_transactions_to_settle_bill()
members = defaultdict(int) members = defaultdict(int)
#We should have the same values between transactions and project balances # We should have the same values between transactions and project balances
for t in transactions: for t in transactions:
members[t['ower']]-=t['amount'] members[t['ower']] -= t['amount']
members[t['receiver']]+=t['amount'] members[t['receiver']] += t['amount']
balance = models.Project.query.get("raclette").balance balance = models.Project.query.get("raclette").balance
for m, a in members.items(): for m, a in members.items():
self.assertEqual(a, balance[m.id]) self.assertEqual(a, balance[m.id])
@ -805,6 +805,7 @@ class BudgetTestCase(TestCase):
class APITestCase(TestCase): class APITestCase(TestCase):
"""Tests the API""" """Tests the API"""
def api_create(self, name, id=None, password=None, contact=None): def api_create(self, name, id=None, password=None, contact=None):
@ -1092,7 +1093,7 @@ class APITestCase(TestCase):
def test_username_xss(self): def test_username_xss(self):
# create a project # create a project
#self.api_create("raclette") # self.api_create("raclette")
self.post_project("raclette") self.post_project("raclette")
self.login("raclette") self.login("raclette")
@ -1162,7 +1163,9 @@ class APITestCase(TestCase):
self.assertStatus(200, req) self.assertStatus(200, req)
self.assertEqual(expected, json.loads(req.data.decode('utf-8'))) self.assertEqual(expected, json.loads(req.data.decode('utf-8')))
class ServerTestCase(APITestCase): class ServerTestCase(APITestCase):
def setUp(self): def setUp(self):
run.configure() run.configure()
super(ServerTestCase, self).setUp() super(ServerTestCase, self).setUp()