From f5ec1b0136d98120e01241bbbd1acf57e3d5bb51 Mon Sep 17 00:00:00 2001
From: Nicolas Vanvyve <nicolas.vanvyve@student.uclouvain.be>
Date: Mon, 13 Jan 2020 17:13:31 +0100
Subject: [PATCH] Remove useless variable and check json format

---
 ihatemoney/web.py | 19 ++++++++++++++++---
 1 file changed, 16 insertions(+), 3 deletions(-)

diff --git a/ihatemoney/web.py b/ihatemoney/web.py
index c390548e..be39feb8 100644
--- a/ihatemoney/web.py
+++ b/ihatemoney/web.py
@@ -400,9 +400,8 @@ def edit_project():
 def upload_json():
     form = UploadForm()
     if form.validate_on_submit():
-        file = form.file.data.stream.read()
         try:
-            import_project(file, g.project)
+            import_project(form.file.data.stream, g.project)
             flash(_("Project successfully uploaded"))
         except ValueError:
             flash(_("Invalid JSON"), category="error")
@@ -412,8 +411,22 @@ def upload_json():
 
 
 def import_project(file, project):
+    json_file = json.load(file)
+
+    # Check if JSON is correct
+    attr = ["what", "payer_name", "payer_weight", "amount", "date", "owers"]
+    attr.sort()
+    for e in json_file:
+        if len(e) != len(attr):
+            raise ValueError
+        list_attr = []
+        for i in e:
+            list_attr.append(i)
+        list_attr.sort()
+        if list_attr != attr:
+            raise ValueError
+
     # From json : export list of members
-    json_file = json.loads(file)
     members_json = get_members(json_file)
     members = project.members
     members_already_here = list()