almet/la-chariotte
1
0
Fork 0
mirror of https://framagit.org/la-chariotte/la-chariotte.git synced 2025-05-01 19:32:26 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions

Prevent conflicting usage of comma in CSV files

Browse source
This commit is contained in:
xmeunier 2025-01-05 13:46:40 +01:00
parent 10aed1560b
commit 18249653f9
2 changed files with 3 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
la_chariotte/order/views/grouped_order.py
View file

@ -341,7 +341,7 @@ class ExportGroupOrderEmailAdressesToDownloadView(UserPassesTestMixin, generic.V
response = http.HttpResponse(content_type="text/csv")
filename = f"commande _{grouped_order.name.replace(' ', '_')}"
response["Content-Disposition"] = f'attachment; filename="{filename}.csv"'
writer = csv.writer(response)
writer = csv.writer(response, delimiter=";")
for email in email_list:
writer.writerow([email])
return response
@ -361,7 +361,7 @@ class ExportGroupedOrderToCSVView(GroupedOrderExportView):
"Content-Disposition": f'attachment; filename="{ context["object"].name }-commandes"'
},
)
writer = csv.writer(response)
writer = csv.writer(response, delimiter=";")
# write headers rows
row = ["", ""]

2
la_chariotte/tests/test_order_views_grouped_order.py
View file

@ -1629,7 +1629,7 @@ class TestExportGroupedOrderToCSVView:
assert response.status_code == 200
content = response.content.decode("utf-8")
csv_reader = csv.reader(StringIO(content))
csv_reader = csv.reader(StringIO(content), delimiter=";")
body = list(csv_reader)
created_date = f"{timezone.now().strftime('%d/%m/%Y')}"
created_time = f"{timezone.now().strftime('%H:%M')}"