fix(helm): reference secret-env by fullname instead release-name (#2406)

Related to helm Charts:
Currently the reference to secret is done by
```          
envFrom:
- secretRef:
  name: {{ .Release.Name }}-env
```

[Link](https://github.com/umap-project/umap/blob/master/charts/umap/templates/deployment.yaml#L67C1-L69C44)

but secret object is created like this:
```
metadata:
  name: {{ include "umap.fullname" . }}-env
```

[Link](https://github.com/umap-project/umap/blob/master/charts/umap/templates/secret-env.yaml#L4C3-L4C4)

Works as long as no Sub-Chart feature is used, when individual
configuration is stored within a git repo.
Then the subchart name is added to fullname. (And I think if custom
fullName is set)

To be safe, `{{ include "umap.fullname" . }}` is correct. 

Should be no breaking change, when it is working at the moment. (Because
then both return same value)
It is only a breaking change, if it is not working at the moment.
This commit is contained in:
David Larlet 2025-01-27 09:56:29 -05:00 committed by GitHub
commit 088f682247
No known key found for this signature in database
GPG key ID: B5690EEEBB952194

View file

@ -66,7 +66,7 @@ spec:
{{- end }} {{- end }}
envFrom: envFrom:
- secretRef: - secretRef:
name: {{ .Release.Name }}-env name: {{ include "umap.fullname" . }}-env
volumeMounts: volumeMounts:
- name: config - name: config
mountPath: /etc/umap/ mountPath: /etc/umap/
@ -80,7 +80,7 @@ spec:
volumes: volumes:
- name: config - name: config
secret: secret:
secretName: {{ .Release.Name }}-config secretName: {{ include "umap.fullname" . }}-config
- name: statics - name: statics
emptyDir: {} emptyDir: {}
{{- if .Values.persistence.enabled }} {{- if .Values.persistence.enabled }}