diff --git a/umap/static/umap/css/dialog.css b/umap/static/umap/css/dialog.css index 9fb2c67e..a3ffca7e 100644 --- a/umap/static/umap/css/dialog.css +++ b/umap/static/umap/css/dialog.css @@ -11,8 +11,29 @@ color: var(--text-color); border-radius: 5px; overflow-y: auto; + height: fit-content; + max-height: 90vh; } -.umap-dialog .umap-close-link { - float: right; - width: 100px; +:where([data-component="no-dialog"]:not([hidden])) { + display: block; + position: relative; +} +:where([data-component*="dialog"] menu) { + display: flex; + gap: calc(var(--gutter) / 2); + justify-content: flex-end; + margin: 0; + padding: 0; +} +:where([data-component*="dialog"] [data-ref="fieldset"]) { + border: 0; + margin: unset; + padding: unset; +} +/* hack for Firefox */ +@-moz-document url-prefix() { + [data-component="no-dialog"]:not([hidden]) { + inset-inline-start: 0; + transform: none; + } } diff --git a/umap/static/umap/js/components/alerts/alert.css b/umap/static/umap/js/components/alerts/alert.css index 737ee71a..af445e6f 100644 --- a/umap/static/umap/js/components/alerts/alert.css +++ b/umap/static/umap/js/components/alerts/alert.css @@ -1,4 +1,4 @@ -[role="dialog"] { +.umap-alert[role="dialog"] { box-sizing: border-box; min-height: 46px; line-height: 46px; @@ -20,36 +20,36 @@ width: max-content; z-index: var(--zindex-alert); } -[role="dialog"] > div { +.umap-alert[role="dialog"] > div { margin: 0 auto; min-width: 60%; background-size: 20px; background-position: 0 15px; padding-left: 28px; } -[role="dialog"][data-level="info"] > div { +.umap-alert[role="dialog"][data-level="info"] > div { background-image: url('../../../img/alert-icon-info.svg'); background-repeat: no-repeat; } -[role="dialog"][data-level="success"] > div { +.umap-alert[role="dialog"][data-level="success"] > div { background-image: url('../../../img/alert-icon-success.svg'); background-repeat: no-repeat; } -[role="dialog"][data-level="error"] > div { +.umap-alert[role="dialog"][data-level="error"] > div { background-image: url('../../../img/alert-icon-error.svg'); background-repeat: no-repeat; } -[role="dialog"][data-level="error"] { +.umap-alert[role="dialog"][data-level="error"] { background-color: var(--color-darkRed); } -[role="dialog"] a { +.umap-alert[role="dialog"] a { text-decoration: underline; } -[role="dialog"] label { +.umap-alert[role="dialog"] label { font-size: .8rem; font-weight: normal; } -[role="dialog"] a[target="_blank"] { +.umap-alert[role="dialog"] a[target="_blank"] { background: url('../../../img/icon-external-link.svg') no-repeat right center; padding-right: 14px; background-size: 12px; @@ -127,7 +127,7 @@ h3[role="alert"] + p { #link-wrapper { margin-bottom: 1rem; } -[role="dialog"] #conflict-wrapper a[target="_blank"] { +.umap-alert[role="dialog"] #conflict-wrapper a[target="_blank"] { background-position-y: 16px; } diff --git a/umap/static/umap/js/modules/autocomplete.js b/umap/static/umap/js/modules/autocomplete.js index 8e4bfae2..54f7697a 100644 --- a/umap/static/umap/js/modules/autocomplete.js +++ b/umap/static/umap/js/modules/autocomplete.js @@ -45,6 +45,7 @@ export class BaseAutocomplete { placeholder: this.options.placeholder, autocomplete: 'off', className: this.options.className, + name: this.options.name || 'autocomplete' }) DomEvent.on(this.input, 'keydown', this.onKeyDown, this) DomEvent.on(this.input, 'keyup', this.onKeyUp, this) diff --git a/umap/static/umap/js/modules/help.js b/umap/static/umap/js/modules/help.js index fe0a8460..aafbc42e 100644 --- a/umap/static/umap/js/modules/help.js +++ b/umap/static/umap/js/modules/help.js @@ -165,6 +165,7 @@ const ENTRIES = { export default class Help { constructor(map) { this.map = map + this.dialog = new U.Dialog() this.isMacOS = /mac/i.test( // eslint-disable-next-line compat/compat -- Fallback available. navigator.userAgentData ? navigator.userAgentData.platform : navigator.platform @@ -207,7 +208,7 @@ export default class Help { }) } } - this.map.dialog.open({ content: container, className: 'dark' }) + this.dialog.open({ template: container, className: 'dark', cancel: false, accept: false }) } button(container, entries, classname) { @@ -241,10 +242,10 @@ export default class Help { const actionsContainer = DomUtil.create('ul', 'umap-edit-actions', container) const addAction = (action) => { const actionContainer = DomUtil.add('li', '', actionsContainer) - DomUtil.add('i', action.options.className, actionContainer), - DomUtil.add('span', '', actionContainer, action.options.tooltip) + DomUtil.add('i', action.options.className, actionContainer) + DomUtil.add('span', '', actionContainer, action.options.tooltip) DomEvent.on(actionContainer, 'click', action.addHooks, action) - DomEvent.on(actionContainer, 'click', this.map.dialog.close, this.map.dialog) + DomEvent.on(actionContainer, 'click', this.dialog.close, this.dialog) } title.textContent = translate('Where do we go from here?') for (const id in this.map.helpMenuActions) { diff --git a/umap/static/umap/js/modules/importer.js b/umap/static/umap/js/modules/importer.js index ba227fd9..65069c09 100644 --- a/umap/static/umap/js/modules/importer.js +++ b/umap/static/umap/js/modules/importer.js @@ -53,7 +53,7 @@ export default class Importer { this.TYPES = ['geojson', 'csv', 'gpx', 'kml', 'osm', 'georss', 'umap'] this.IMPORTERS = [] this.loadImporters() - this.dialog = new Dialog(this.map._controlContainer) + this.dialog = new Dialog() } loadImporters() { @@ -114,7 +114,7 @@ export default class Importer { } get action() { - return this.qs('[name=action]:checked').value + return this.qs('[name=action]:checked')?.value } get layerId() { @@ -234,7 +234,7 @@ export default class Importer { } submit() { - let hasErrors = false + let hasErrors if (this.format === 'umap') { hasErrors = !this.full() } else if (!this.url) { @@ -242,7 +242,7 @@ export default class Importer { } else if (this.action) { hasErrors = !this[this.action]() } - if (!hasErrors) { + if (hasErrors === false) { Alert.info(translate('Data successfully imported!')) } } diff --git a/umap/static/umap/js/modules/importers/communesfr.js b/umap/static/umap/js/modules/importers/communesfr.js index 6a7348cc..6b4c0f15 100644 --- a/umap/static/umap/js/modules/importers/communesfr.js +++ b/umap/static/umap/js/modules/importers/communesfr.js @@ -37,8 +37,10 @@ export class Importer { this.autocomplete = new Autocomplete(container, options) importer.dialog.open({ - content: container, + template: container, className: `${this.id} importer dark`, + cancel: false, + accept: false, }) } } diff --git a/umap/static/umap/js/modules/importers/datasets.js b/umap/static/umap/js/modules/importers/datasets.js index a376f696..eb2c4049 100644 --- a/umap/static/umap/js/modules/importers/datasets.js +++ b/umap/static/umap/js/modules/importers/datasets.js @@ -30,13 +30,15 @@ export class Importer { importer.format = select.options[select.selectedIndex].dataset.format importer.layerName = select.options[select.selectedIndex].textContent } - importer.dialog.close() } - L.DomUtil.createButton('', container, translate('Choose this dataset'), confirm) - importer.dialog.open({ - content: container, - className: `${this.id} importer dark`, - }) + importer.dialog + .open({ + template: container, + className: `${this.id} importer dark`, + accept: translate('Choose this dataset'), + cancel: false, + }) + .then(confirm) } } diff --git a/umap/static/umap/js/modules/importers/geodatamine.js b/umap/static/umap/js/modules/importers/geodatamine.js index cfbef595..816fcbcb 100644 --- a/umap/static/umap/js/modules/importers/geodatamine.js +++ b/umap/static/umap/js/modules/importers/geodatamine.js @@ -25,7 +25,6 @@ const TEMPLATE = ` - ` class Autocomplete extends SingleMixin(BaseAjax) { @@ -66,7 +65,6 @@ export class Importer { } else { console.error(response) } - const asPoint = container.querySelector('[name=aspoint]') this.autocomplete = new Autocomplete(container.querySelector('#boundary'), { placeholder: translate('Search admin boundary'), url: `${this.baseUrl}/boundaries/search?text={q}`, @@ -75,21 +73,23 @@ export class Importer { boundaryName = choice.item.label }, }) - const confirm = () => { + const confirm = (form) => { if (!boundary || !select.value) { Alert.error(translate('Please choose a theme and a boundary first.')) return } - importer.url = `${this.baseUrl}/data/${select.value}/${boundary}?format=geojson&aspoint=${asPoint.checked}` + importer.url = `${this.baseUrl}/data/${form.theme}/${boundary}?format=geojson&aspoint=${Boolean(form.aspoint)}` importer.format = 'geojson' importer.layerName = `${boundaryName} — ${select.options[select.selectedIndex].textContent}` - importer.dialog.close() } - DomEvent.on(container.querySelector('button'), 'click', confirm) - importer.dialog.open({ - content: container, - className: `${this.id} importer dark`, - }) + importer.dialog + .open({ + template: container, + className: `${this.id} importer dark`, + accept: translate('Choose this data'), + cancel: false, + }) + .then(confirm) } } diff --git a/umap/static/umap/js/modules/importers/overpass.js b/umap/static/umap/js/modules/importers/overpass.js index 8bd7f058..4e9c5190 100644 --- a/umap/static/umap/js/modules/importers/overpass.js +++ b/umap/static/umap/js/modules/importers/overpass.js @@ -11,7 +11,7 @@ const TEMPLATE = `