From c79660c354c0c453bb04fd60c4d432bf9eb74169 Mon Sep 17 00:00:00 2001 From: Yohan Boniface Date: Wed, 17 Apr 2024 14:32:25 +0200 Subject: [PATCH 1/2] chore: allow to set playwright timeout from env var so we can increase it in the CI --- .github/workflows/test-docs.yml | 1 + umap/tests/integration/conftest.py | 4 +++- 2 files changed, 4 insertions(+), 1 deletion(-) diff --git a/.github/workflows/test-docs.yml b/.github/workflows/test-docs.yml index 4ed13aba..49bdc03e 100644 --- a/.github/workflows/test-docs.yml +++ b/.github/workflows/test-docs.yml @@ -46,6 +46,7 @@ jobs: env: DJANGO_SETTINGS_MODULE: 'umap.tests.settings' UMAP_SETTINGS: 'umap/tests/settings.py' + PLAYWRIGHT_TIMEOUT: '10000' lint: runs-on: ubuntu-latest steps: diff --git a/umap/tests/integration/conftest.py b/umap/tests/integration/conftest.py index 6ed9eb59..89a115e9 100644 --- a/umap/tests/integration/conftest.py +++ b/umap/tests/integration/conftest.py @@ -1,9 +1,11 @@ +import os + import pytest @pytest.fixture(autouse=True) def set_timeout(context): - context.set_default_timeout(7500) + context.set_default_timeout(os.environ.get("PLAYWRIGHT_TIMEOUT", 7500)) @pytest.fixture From d2ba1deac74ab320f8b9f157dd2944d810469f18 Mon Sep 17 00:00:00 2001 From: Yohan Boniface Date: Wed, 17 Apr 2024 14:55:11 +0200 Subject: [PATCH 2/2] Update .github/workflows/test-docs.yml Co-authored-by: David Larlet <3556+davidbgk@users.noreply.github.com> --- .github/workflows/test-docs.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/test-docs.yml b/.github/workflows/test-docs.yml index 49bdc03e..c6b392a4 100644 --- a/.github/workflows/test-docs.yml +++ b/.github/workflows/test-docs.yml @@ -46,7 +46,7 @@ jobs: env: DJANGO_SETTINGS_MODULE: 'umap.tests.settings' UMAP_SETTINGS: 'umap/tests/settings.py' - PLAYWRIGHT_TIMEOUT: '10000' + PLAYWRIGHT_TIMEOUT: '20000' lint: runs-on: ubuntu-latest steps: