almet/umap
1
0
Fork 0
mirror of https://github.com/umap-project/umap.git synced 2025-04-29 20:02:36 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

fix: only allow to set a map as sync when it is already saved (#2465)

Browse source
This commit is contained in:
Yohan Boniface 2025-01-31 17:10:22 +01:00 committed by GitHub
commit 1d6e74e1d2
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
2 changed files with 4 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
umap/static/umap/js/modules/umap.js
View file

@ -1111,7 +1111,7 @@ export default class Umap extends ServerStored {
this._editOverlay(container) this._editOverlay(container)
this._editBounds(container) this._editBounds(container)
this._editSlideshow(container) this._editSlideshow(container)
if (this.properties.websocketEnabled) { if (this.properties.websocketEnabled && this.id) {
this._editSync(container) this._editSync(container)
} }
this._advancedActions(container) this._advancedActions(container)

3
umap/tests/integration/test_websocket_sync.py
View file

@ -503,9 +503,12 @@ def test_create_and_sync_map(new_page, asgi_live_server, tilelayer, login, user)
# Create a syncable map with peerA # Create a syncable map with peerA
peerA = login(user, prefix="Page A") peerA = login(user, prefix="Page A")
peerA.goto(f"{asgi_live_server.url}/en/map/new/") peerA.goto(f"{asgi_live_server.url}/en/map/new/")
peerA.get_by_role("link", name="Map advanced properties").click()
expect(peerA.get_by_text("Real-time collaboration", exact=True)).to_be_hidden()
with peerA.expect_response(re.compile("./map/create/.*")): with peerA.expect_response(re.compile("./map/create/.*")):
peerA.get_by_role("button", name="Save Draft").click() peerA.get_by_role("button", name="Save Draft").click()
peerA.get_by_role("link", name="Map advanced properties").click() peerA.get_by_role("link", name="Map advanced properties").click()
expect(peerA.get_by_text("Real-time collaboration", exact=True)).to_be_visible()
peerA.get_by_text("Real-time collaboration", exact=True).click() peerA.get_by_text("Real-time collaboration", exact=True).click()
peerA.get_by_text("Enable real-time").click() peerA.get_by_text("Enable real-time").click()
peerA.get_by_role("link", name="Update permissions and editors").click() peerA.get_by_role("link", name="Update permissions and editors").click()