From 4af5089bcc652fc32943fe79f21be1f0676f5773 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Alexis=20M=C3=A9taireau?= <alexis@notmyidea.org>
Date: Thu, 26 Sep 2024 10:22:43 +0200
Subject: [PATCH] ci: Skip intermittent-failing tests when on the CI.

A few tests have been failing randomly, leading to developers not having
a lot of trust in the CI, and having to retrigger the runs.

Here is the list of tests:

- `test_should_honor_toZoom`
- `test_default_view_locate`
- `test_umap_import_from_textarea`

This skips these tests when running in the CI, by looking at the `CI`
environment variable, set by Github Actions [0]

[0] https://docs.github.com/en/actions/writing-workflows/choosing-what-your-workflow-does/store-information-in-variables#default-environment-variables
---
 umap/tests/integration/test_datalayer.py | 6 +++++-
 umap/tests/integration/test_import.py    | 5 +++++
 umap/tests/integration/test_map.py       | 5 +++++
 3 files changed, 15 insertions(+), 1 deletion(-)

diff --git a/umap/tests/integration/test_datalayer.py b/umap/tests/integration/test_datalayer.py
index e5161f2f..9122e12b 100644
--- a/umap/tests/integration/test_datalayer.py
+++ b/umap/tests/integration/test_datalayer.py
@@ -1,5 +1,5 @@
 import json
-
+import os
 import re
 
 import pytest
@@ -55,6 +55,10 @@ def test_should_honour_fromZoom(live_server, map, datalayer, page):
     expect(markers).to_be_visible()
 
 
+@pytest.mark.skipif(
+    os.environ.get("CI", "false") == "true",
+    reason="Test is failing intermittently, skipping in the CI",
+)
 def test_should_honour_toZoom(live_server, map, datalayer, page):
     set_options(datalayer, displayOnLoad=True, toZoom=6)
     page.goto(f"{live_server.url}{map.get_absolute_url()}#7/48.55/14.68")
diff --git a/umap/tests/integration/test_import.py b/umap/tests/integration/test_import.py
index c696638c..73bee1ad 100644
--- a/umap/tests/integration/test_import.py
+++ b/umap/tests/integration/test_import.py
@@ -1,4 +1,5 @@
 import json
+import os
 import platform
 import re
 from pathlib import Path
@@ -70,6 +71,10 @@ def test_umap_import_from_file(live_server, tilelayer, page):
     expect(nonloaded).to_have_count(1)
 
 
+@pytest.mark.skipif(
+    os.environ.get("CI", "false") == "true",
+    reason="Test is failing intermittently, skipping in the CI",
+)
 def test_umap_import_from_textarea(live_server, tilelayer, page, settings):
     settings.UMAP_ALLOW_ANONYMOUS = True
     page.goto(f"{live_server.url}/map/new/")
diff --git a/umap/tests/integration/test_map.py b/umap/tests/integration/test_map.py
index 6eb979e8..3dd89797 100644
--- a/umap/tests/integration/test_map.py
+++ b/umap/tests/integration/test_map.py
@@ -1,3 +1,4 @@
+import os
 import re
 
 import pytest
@@ -147,6 +148,10 @@ def test_default_view_latest_with_polygon(map, live_server, page):
     expect(layers).to_have_count(1)
 
 
+@pytest.mark.skipif(
+    os.environ.get("CI", "false") == "true",
+    reason="Test is failing intermittently, skipping in the CI",
+)
 def test_default_view_locate(browser, live_server, map):
     context = browser.new_context(
         geolocation={"longitude": 8.52967, "latitude": 39.16267},