From 50b8b66261898efead0420a85bfdf4d3bf531f98 Mon Sep 17 00:00:00 2001 From: Yohan Boniface Date: Mon, 31 Jul 2023 20:58:25 +0200 Subject: [PATCH] Simplify Panel popup inheritance Panel is not a real popup, so the less we inherit the better --- umap/static/umap/js/umap.popup.js | 9 +++------ 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/umap/static/umap/js/umap.popup.js b/umap/static/umap/js/umap.popup.js index 173cba39..9fd96b3c 100644 --- a/umap/static/umap/js/umap.popup.js +++ b/umap/static/umap/js/umap.popup.js @@ -63,8 +63,8 @@ L.U.Popup.Panel = L.U.Popup.extend({ return button }, - update: function () { - this.feature.map.ui.openPanel({ + onAdd: function (map) { + map.ui.openPanel({ data: { html: this._content }, actions: [this.allButton()], }) @@ -72,12 +72,9 @@ L.U.Popup.Panel = L.U.Popup.extend({ onRemove: function (map) { map.ui.closePanel() - L.U.Popup.prototype.onRemove.call(this, map) }, - _initLayout: function () { - this._container = L.DomUtil.create('span') - }, + update: function () {}, _updateLayout: function () {}, _updatePosition: function () {}, _adjustPan: function () {},