almet/umap
1
0
Fork 0
mirror of https://github.com/umap-project/umap.git synced 2025-04-28 19:42:36 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

fixup: cache wikipedia calls and be a bit more defensive

Browse source
This commit is contained in:
Yohan Boniface 2024-12-13 15:28:36 +01:00
parent b7173d4629
commit 6e5540fe79
1 changed files with 25 additions and 11 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

36
umap/static/umap/js/modules/rendering/template.js
View file

@ -243,11 +243,11 @@ class OSM extends PopupTemplate {
}
}
const _WIKIPEDIA_CACHE = {}
class Wikipedia extends PopupTemplate {
async renderBody(feature) {
const body = document.createElement('div')
const wikipedia = feature.properties.wikipedia
if (!wikipedia) return 'No data'
async callWikipedia(wikipedia) {
if (wikipedia && _WIKIPEDIA_CACHE[wikipedia]) return _WIKIPEDIA_CACHE[wikipedia]
// Wikipedia value should be in form of "{locale}:{title}", according to https://wiki.openstreetmap.org/wiki/Key:wikipedia
const [locale, page] = wikipedia.split(':')
const url = `https://${locale}.wikipedia.org/w/api.php?action=query&format=json&origin=*&pithumbsize=500&prop=extracts|pageimages&titles=${page}`
@ -255,15 +255,29 @@ class Wikipedia extends PopupTemplate {
const response = await request.get(url)
if (response?.ok) {
const data = await response.json()
_WIKIPEDIA_CACHE[wikipedia] = data
return data
}
}
async renderBody(feature) {
const body = document.createElement('div')
const wikipedia = feature.properties.wikipedia
if (!wikipedia) return ''
const data = await this.callWikipedia(wikipedia)
if (data) {
const page = Object.values(data.query.pages)[0]
const title = page.title
const extract = page.extract
const thumbnail = page.thumbnail.source
body.appendChild(
Utils.loadTemplate(
`<div><h3>${title}</h3><img src="${thumbnail}" />${extract}</div>`
)
const title = page.title || feature.getDisplayName()
const extract = page.extract || ''
const thumbnail = page.thumbnail?.source
const [content, { image }] = Utils.loadTemplateWithRefs(
`<div><h3>${title}</h3><img data-ref="image" hidden src="" />${extract}</div>`
)
if (thumbnail) {
image.src = thumbnail
image.hidden = false
}
body.appendChild(content)
}
return body
}