almet/umap
1
0
Fork 0
mirror of https://github.com/umap-project/umap.git synced 2025-04-29 03:42:37 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

chore: do not use Number.isNaN in special cases

Browse source
This commit is contained in:
David Larlet 2024-06-25 18:14:34 -04:00
parent 5c88502a2e
commit 7a82b6547e
No known key found for this signature in database
GPG key ID: 3E2953A359E7E7BD
1 changed files with 8 additions and 8 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

16
umap/static/umap/js/modules/facets.js
View file

@ -36,16 +36,16 @@ export default class Facets {
case 'datetime': case 'datetime':
case 'number': case 'number':
if (!Number.isNaN(value)) { if (!Number.isNaN(value)) {
if ( // Special cases where we want to be lousy when checking isNaN without
Number.isNaN(properties[name].min) || // coercing to a Number first because we handle multiple types.
properties[name].min > value // See https://developer.mozilla.org/en-US/docs/Web/JavaScript/
) { // Reference/Global_Objects/Number/isNaN
// biome-ignore lint/suspicious/noGlobalIsNan: see above.
if (isNaN(properties[name].min) || properties[name].min > value) {
properties[name].min = value properties[name].min = value
} }
if ( // biome-ignore lint/suspicious/noGlobalIsNan: see above.
Number.isNaN(properties[name].max) || if (isNaN(properties[name].max) || properties[name].max < value) {
properties[name].max < value
) {
properties[name].max = value properties[name].max = value
} }
} }