almet/umap
1
0
Fork 0
mirror of https://github.com/umap-project/umap.git synced 2025-04-30 20:12:37 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

feat(sync): initialize datalayers internal objects in the constructor.

Browse source 
Otherwise, an event can come from the websocket, trying to update an
`undefined` property.
This commit is contained in:
Alexis Métaireau 2024-04-30 00:23:36 +02:00
parent b956101d5d
commit 9a74cc370c
2 changed files with 8 additions and 7 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
umap/static/umap/js/modules/sync/updaters.js
View file

@ -48,7 +48,7 @@ export class MapUpdater extends BaseUpdater {
export class DatalayerUpdater extends BaseUpdater { export class DatalayerUpdater extends BaseUpdater {
update({ key, metadata, value }) { update({ key, metadata, value }) {
const datalayer = this.getLayerFromID(metadata.id) const datalayer = this.getLayerFromID(metadata.id)
console.log(datalayer, key, value) console.log('datalayer', datalayer, key, value)
this.updateObjectValue(datalayer, key, value) this.updateObjectValue(datalayer, key, value)
datalayer.render([key]) datalayer.render([key])
} }

13
umap/static/umap/js/umap.layer.js
View file

@ -74,6 +74,10 @@ U.Layer.Cluster = L.MarkerClusterGroup.extend({
L.MarkerClusterGroup.prototype.initialize.call(this, options) L.MarkerClusterGroup.prototype.initialize.call(this, options)
this._markerCluster = U.MarkerCluster this._markerCluster = U.MarkerCluster
this._layers = [] this._layers = []
if (!U.Utils.isObject(this.datalayer.options.cluster)) {
this.datalayer.options.cluster = {}
}
}, },
onRemove: function (map) { onRemove: function (map) {
@ -97,9 +101,6 @@ U.Layer.Cluster = L.MarkerClusterGroup.extend({
}, },
getEditableOptions: function () { getEditableOptions: function () {
if (!U.Utils.isObject(this.datalayer.options.cluster)) {
this.datalayer.options.cluster = {}
}
return [ return [
[ [
'options.cluster.radius', 'options.cluster.radius',
@ -351,6 +352,9 @@ U.Layer.Heat = L.HeatLayer.extend({
initialize: function (datalayer) { initialize: function (datalayer) {
this.datalayer = datalayer this.datalayer = datalayer
L.HeatLayer.prototype.initialize.call(this, [], this.datalayer.options.heat) L.HeatLayer.prototype.initialize.call(this, [], this.datalayer.options.heat)
if (!U.Utils.isObject(this.datalayer.options.heat)) {
this.datalayer.options.heat = {}
}
}, },
addLayer: function (layer) { addLayer: function (layer) {
@ -383,9 +387,6 @@ U.Layer.Heat = L.HeatLayer.extend({
}, },
getEditableOptions: function () { getEditableOptions: function () {
if (!U.Utils.isObject(this.datalayer.options.heat)) {
this.datalayer.options.heat = {}
}
return [ return [
[ [
'options.heat.radius', 'options.heat.radius',