From ad4d6ac6728d688ce75f314ebfd6e0860ea2ec11 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Alexis=20M=C3=A9taireau?= <alexis@notmyidea.org>
Date: Wed, 15 May 2024 12:21:37 +0200
Subject: [PATCH] test(sync): Ensure polygons and their edits can be synced

---
 umap/tests/integration/test_websocket_sync.py | 71 +++++++++++++++++--
 1 file changed, 67 insertions(+), 4 deletions(-)

diff --git a/umap/tests/integration/test_websocket_sync.py b/umap/tests/integration/test_websocket_sync.py
index 53922303..f369bf26 100644
--- a/umap/tests/integration/test_websocket_sync.py
+++ b/umap/tests/integration/test_websocket_sync.py
@@ -12,17 +12,14 @@ DATALAYER_UPDATE = re.compile(r".*/datalayer/update/.*")
 def test_websocket_connection_can_sync_markers(
     context, live_server, websocket_server, tilelayer
 ):
-    # Create a new map
     map = MapFactory(name="sync", edit_status=Map.ANONYMOUS)
     map.settings["properties"]["syncEnabled"] = True
     map.save()
     DataLayerFactory(map=map, data={})
 
-    # Now navigate to this map from two tabs
+    # Create two tabs
     peerA = context.new_page()
     peerA.goto(f"{live_server.url}{map.get_absolute_url()}?edit")
-
-    # Now navigate to this map from another tab
     peerB = context.new_page()
     peerB.goto(f"{live_server.url}{map.get_absolute_url()}?edit")
 
@@ -51,6 +48,7 @@ def test_websocket_connection_can_sync_markers(
     expect(a_marker_pane).to_have_count(2)
     expect(b_marker_pane).to_have_count(2)
 
+    # FIXME: find a better locator for markers
     b_first_marker = peerB.locator("div:nth-child(4) > div:nth-child(2)").first
     a_first_marker = peerA.locator("div:nth-child(4) > div:nth-child(2)").first
 
@@ -62,8 +60,73 @@ def test_websocket_connection_can_sync_markers(
     assert b_old_bbox is not b_first_marker.bounding_box()
     a_first_marker.bounding_box() == b_first_marker.bounding_box()
 
+    # Delete a marker from peer A and check it's been deleted on peer B
     a_first_marker.click(button="right")
     peerA.on("dialog", lambda dialog: dialog.accept())
     peerA.get_by_role("link", name="Delete this feature").click()
     expect(a_marker_pane).to_have_count(1)
     expect(b_marker_pane).to_have_count(1)
+
+
+def test_websocket_connection_can_sync_polygons(
+    context, live_server, websocket_server, tilelayer
+):
+    map = MapFactory(name="sync", edit_status=Map.ANONYMOUS)
+    map.settings["properties"]["syncEnabled"] = True
+    map.save()
+    DataLayerFactory(map=map, data={})
+
+    # Create two tabs
+    peerA = context.new_page()
+    peerA.goto(f"{live_server.url}{map.get_absolute_url()}?edit")
+    peerB = context.new_page()
+    peerB.goto(f"{live_server.url}{map.get_absolute_url()}?edit")
+
+    b_map_el = peerB.locator("#map")
+
+    # Click on the Draw a polygon button on a new map.
+    create_line = peerA.locator(".leaflet-control-toolbar ").get_by_title(
+        "Draw a polygon"
+    )
+    create_line.click()
+
+    a_polygons = peerA.locator(".leaflet-overlay-pane path[fill='DarkBlue']")
+    b_polygons = peerB.locator(".leaflet-overlay-pane path[fill='DarkBlue']")
+    expect(a_polygons).to_have_count(0)
+    expect(b_polygons).to_have_count(0)
+
+    # Click on the map, it will create a polygon.
+    map = peerA.locator("#map")
+    map.click(position={"x": 200, "y": 200})
+    map.click(position={"x": 100, "y": 200})
+    map.click(position={"x": 100, "y": 100})
+    map.click(position={"x": 100, "y": 100})
+
+    # It is created on peerA, but not yet synced
+    expect(a_polygons).to_have_count(1)
+    expect(b_polygons).to_have_count(0)
+
+    # Escaping the edition syncs
+    peerA.keyboard.press("Escape")
+    expect(a_polygons).to_have_count(1)
+    expect(b_polygons).to_have_count(1)
+
+    # change the geometry by moving a point on peer B
+    a_polygon = peerA.locator("path")
+    b_polygon = peerB.locator("path")
+    b_polygon_bbox_t1 = b_polygon.bounding_box()
+    a_polygon_bbox_t1 = a_polygon.bounding_box()
+    assert b_polygon_bbox_t1 == a_polygon_bbox_t1
+
+    peerB.locator("path").click()
+    peerB.get_by_role("link", name="Toggle edit mode (⇧+Click)").click()
+
+    edited_vertex = peerB.locator("div:nth-child(6)").first
+    edited_vertex.drag_to(b_map_el, target_position={"x": 250, "y": 250})
+    peerB.keyboard.press("Escape")
+
+    b_polygon_bbox_t2 = b_polygon.bounding_box()
+    a_polygon_bbox_t2 = a_polygon.bounding_box()
+
+    assert b_polygon_bbox_t2 != b_polygon_bbox_t1
+    assert b_polygon_bbox_t2 == a_polygon_bbox_t2