almet/umap
1
0
Fork 0
mirror of https://github.com/umap-project/umap.git synced 2025-04-28 19:42:36 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

fix(#2355): correctly reset Dialog’s returnValue (#2356)
Some checks are pending
Test & Docs / tests (postgresql, 3.10) (push) Waiting to run
Details
Test & Docs / tests (postgresql, 3.12) (push) Waiting to run
Details
Test & Docs / lint (push) Waiting to run
Details
Test & Docs / docs (push) Waiting to run
Details

Browse source 
Fixes #2355
This commit is contained in:
Yohan Boniface 2024-12-10 13:33:00 +01:00 committed by GitHub
commit c15ecfc29f
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 1 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
umap/static/umap/js/modules/ui/dialog.js
View file

@ -78,7 +78,6 @@ export default class Dialog extends WithTemplate {
event.preventDefault() event.preventDefault()
this.dialog.returnValue = 'accept' this.dialog.returnValue = 'accept'
this.close() this.close()
this.dialog.returnValue = undefined
}) })
} }
this.dialog.addEventListener('keydown', (e) => { this.dialog.addEventListener('keydown', (e) => {
@ -143,6 +142,7 @@ export default class Dialog extends WithTemplate {
close() { close() {
this.toggle(false) this.toggle(false)
this.dialog.returnValue = undefined
} }
toggle(open = false) { toggle(open = false) {