fix: simpler way to deal with positionning contextmenu

Use pageX/Y from the begginning instead of recomputing it later.

umap/static/umap/js/modules/rendering/ui.js

@@ -89,7 +89,7 @@ const FeatureMixin = {
     const items = this._map.getContextMenuItems(event)
     items.push('-', ...this.feature.getContextMenuItems(event))
     this._map.contextmenu.open(
-      [event.originalEvent.clientX, event.originalEvent.clientY],
+      [event.originalEvent.pageX, event.originalEvent.pageY],
       items
     )
   },

umap/static/umap/js/modules/tableeditor.js

@@ -64,7 +64,7 @@ export default class TableEditor extends WithTemplate {
         action: () => this.deleteProperty(property),
       })
     }
-    this.contextmenu.open([event.clientX, event.clientY], actions)
+    this.contextmenu.open([event.pageX, event.pageY], actions)
   }
 
   renderHeaders() {

umap/static/umap/js/modules/ui/base.js

@@ -63,18 +63,16 @@ export class Positioned {
     else this.container.style.bottom = 'initial'
   }
 
-  computePosition([x, y], parent) {
+  computePosition([x, y]) {
     let left
     let top
-    x = x - parent.getBoundingClientRect().left
-    y = y - parent.getBoundingClientRect().top
-    if (x < parent.offsetWidth / 2) {
+    if (x < window.offsetWidth / 2) {
       left = x
     } else {
       left = x - this.container.offsetWidth
     }
-    if (y < parent.offsetHeight / 2) {
-      top = Math.min(y, parent.offsetHeight - this.container.offsetHeight)
+    if (y < window.offsetHeight / 2) {
+      top = Math.min(y, window.offsetHeight - this.container.offsetHeight)
     } else {
       top = Math.max(0, y - this.container.offsetHeight)
     }

umap/static/umap/js/modules/ui/contextmenu.js

@@ -36,12 +36,11 @@ export default class ContextMenu extends Positioned {
         this.container.appendChild(li)
       }
     }
-    const parent = document.elementFromPoint(left, top).closest('.leaflet-container')
-    parent.appendChild(this.container)
+    document.body.appendChild(this.container)
     if (this.options.fixed) {
       this.setPosition({ left, top })
     } else {
-      this.computePosition([left, top], parent)
+      this.computePosition([left, top])
     }
     this.container.querySelector('li > *').focus()
     this.container.addEventListener(

umap/static/umap/js/umap.js

@@ -1773,7 +1773,7 @@ U.Map = L.Map.extend({
   onContextMenu: function (event) {
     const items = this.getContextMenuItems(event)
     this.contextmenu.open(
-      [event.originalEvent.clientX, event.originalEvent.clientY],
+      [event.originalEvent.pageX, event.originalEvent.pageY],
       items
     )
   },