From 453056cb154acc7c628b9848b6bf89166b4d71fa Mon Sep 17 00:00:00 2001 From: Yohan Boniface Date: Wed, 24 Apr 2024 14:17:50 +0200 Subject: [PATCH] feat: remove Map.description The field was not populated since years, and we already have the info inside the JSONB `settings`. --- umap/migrations/0021_remove_map_description.py | 16 ++++++++++++++++ umap/models.py | 8 +++++++- 2 files changed, 23 insertions(+), 1 deletion(-) create mode 100644 umap/migrations/0021_remove_map_description.py diff --git a/umap/migrations/0021_remove_map_description.py b/umap/migrations/0021_remove_map_description.py new file mode 100644 index 00000000..196200a9 --- /dev/null +++ b/umap/migrations/0021_remove_map_description.py @@ -0,0 +1,16 @@ +# Generated by Django 5.0.4 on 2024-04-24 07:50 + +from django.db import migrations + + +class Migration(migrations.Migration): + dependencies = [ + ("umap", "0020_alter_tilelayer_url_template"), + ] + + operations = [ + migrations.RemoveField( + model_name="map", + name="description", + ), + ] diff --git a/umap/models.py b/umap/models.py index 225a305f..6e942fb0 100644 --- a/umap/models.py +++ b/umap/models.py @@ -155,7 +155,6 @@ class Map(NamedModel): (BLOCKED, _("Blocked")), ) slug = models.SlugField(db_index=True) - description = models.TextField(blank=True, null=True, verbose_name=_("description")) center = models.PointField(geography=True, verbose_name=_("center")) zoom = models.IntegerField(default=7, verbose_name=_("zoom")) locate = models.BooleanField( @@ -198,6 +197,13 @@ class Map(NamedModel): objects = models.Manager() public = PublicManager() + @property + def description(self): + try: + return self.settings["properties"]["description"] + except KeyError: + return "" + @property def preview_settings(self): layers = self.datalayer_set.all()