almet/umap
1
0
Fork 0
mirror of https://github.com/umap-project/umap.git synced 2025-04-28 19:42:36 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

fix: display a more usefull message when error in remote data (#2443)
Some checks failed
Test & Docs / tests (postgresql, 3.10) (push) Has been cancelled
Details
Test & Docs / tests (postgresql, 3.12) (push) Has been cancelled
Details
Test & Docs / lint (push) Has been cancelled
Details
Test & Docs / docs (push) Has been cancelled
Details

Browse source 
fix #2379

![Screenshot From 2025-01-23
11-54-29](https://github.com/user-attachments/assets/b2000003-b9c3-404f-be91-0a9b13f512c2)
This commit is contained in:
Yohan Boniface 2025-01-24 09:09:14 +01:00 committed by GitHub
commit ea2bdba270
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 19 additions and 8 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

27
umap/static/umap/js/modules/data/layer.js
View file

@ -302,6 +302,19 @@ export class DataLayer extends ServerStored {
return this.isRemoteLayer() && Boolean(this.options.remoteData?.dynamic)
}
async getUrl(url) {
const response = await this._umap.request.get(url)
return new Promise((resolve) => {
if (response?.ok) return resolve(response.text())
Alert.error(
translate('Cannot load remote data for layer "{layer}" with url "{url}"', {
layer: this.getName(),
url: url,
})
)
})
}
async fetchRemoteData(force) {
if (!this.isRemoteLayer()) return
if (!this.hasDynamicData() && this.hasDataLoaded() && !force) return
@ -310,13 +323,12 @@ export class DataLayer extends ServerStored {
if (this.options.remoteData.proxy) {
url = this._umap.proxyUrl(url, this.options.remoteData.ttl)
}
const response = await this._umap.request.get(url)
if (response?.ok) {
return await this.getUrl(url).then((raw) => {
this.clear()
return this._umap.formatter
.parse(await response.text(), this.options.remoteData.format)
.parse(raw, this.options.remoteData.format)
.then((geojson) => this.fromGeoJSON(geojson))
}
})
}
isLoaded() {
@ -541,10 +553,9 @@ export class DataLayer extends ServerStored {
async importFromUrl(uri, type) {
uri = this._umap.renderUrl(uri)
const response = await this._umap.request.get(uri)
if (response?.ok) {
return this.importRaw(await response.text(), type)
}
return await this.getUrl(uri).then((raw) => {
return this.importRaw(raw, type)
})
}
getColor() {