As far as I understand, it default to `let` in these cases because the tool cannot figure out if a `const` is possible. It has to be checked manually:
```
./node_modules/lebab/bin/index.js --replace "umap/static/umap/js/*.js" --transform let
umap/static/umap/js/umap.xhr.js:
228: warning Unable to transform var (let)
umap/static/umap/js/umap.ui.js:
83: warning Unable to transform var (let)
umap/static/umap/js/umap.slideshow.js:
15: warning Unable to transform var (let)
83: warning Unable to transform var (let)
umap/static/umap/js/umap.popup.js:
100: warning Unable to transform var (let)
umap/static/umap/js/umap.permissions.js:
14: warning Unable to transform var (let)
umap/static/umap/js/umap.layer.js:
195: warning Unable to transform var (let)
436: warning Unable to transform var (let)
568: warning Unable to transform var (let)
584: warning Unable to transform var (let)
989: warning Unable to transform var (let)
1088: warning Unable to transform var (let)
1098: warning Unable to transform var (let)
umap/static/umap/js/umap.js:
124: warning Unable to transform var (let)
223: warning Unable to transform var (let)
343: warning Unable to transform var (let)
376: warning Unable to transform var (let)
406: warning Unable to transform var (let)
849: warning Unable to transform var (let)
732: warning Unable to transform var (let)
948: warning Unable to transform var (let)
959: warning Unable to transform var (let)
878: warning Unable to transform var (let)
1085: warning Unable to transform var (let)
umap/static/umap/js/umap.icon.js:
145: warning Unable to transform var (let)
184: warning Unable to transform var (let)
umap/static/umap/js/umap.forms.js:
453: warning Unable to transform var (let)
umap/static/umap/js/umap.features.js:
15: warning Unable to transform var (let)
101: warning Unable to transform var (let)
143: warning Unable to transform var (let)
373: warning Unable to transform var (let)
429: warning Unable to transform var (let)
890: warning Unable to transform var (let)
949: warning Unable to transform var (let)
umap/static/umap/js/umap.core.js:
149: warning Unable to transform var (let)
175: warning Unable to transform var (let)
umap/static/umap/js/umap.controls.js:
665: warning Unable to transform var (let)
876: warning Unable to transform var (let)
1249: warning Unable to transform var (let)
```
new account at each login:
```
File "/srv/umap/venv/lib/python3.10/site-packages/social_core/backends/base.py", line 83, in pipeline
out = self.run_pipeline(pipeline, pipeline_index, *args, **kwargs)
File "/srv/umap/venv/lib/python3.10/site-packages/social_core/backends/base.py", line 113, in run_pipeline
result = func(*args, **out) or {}
File "/srv/umap/venv/lib/python3.10/site-packages/social_core/pipeline/user.py", line 122, in user_details
strategy.storage.user.changed(user)
File "/srv/umap/venv/lib/python3.10/site-packages/social_django/storage.py", line 16, in changed
user.save()
django.db.utils.IntegrityError: duplicate key value violates unique constraint "auth_user_username_key"
DETAIL: Key (username)=(xxxxx) already exists.
```
Since this commit 97e2df0a8d tests were broken because the URL has an extra date parameter to update the cache for datalayers. With the new regexp, we match these new URLs with the fakeServer from sinon.
Also update sinon to v15.
I missed that one and I fixed a bug in the meantime setting a correct label (vs. invisible placeholder for an input of type range).
I set a fallback on the datalist id in case no label is specified (which is probably not a good idea).
In the same move:
- Map.options.easing is now false by default
- if zoomTo options is set, it should be honoured each time we
use the zoomTo function
fix#679#179
Using Jake Archibald’s tool: https://jakearchibald.github.io/svgomg/ with default settings except keeping width/height attributes because some old browsers require default sizes for rendering (it also avoid huge/100% icons in case the CSS is not applied for whatever reason).
The default django.core.signing Signer uses SHA256 algorithm since Django 3.
Umap used Django 2 in the paste, so people had SHA1 signed anonymous edit URLs,
which became unusable when umap switch to Django 3.
This commit makes them usable again (the new SHA256-signed anonymous edit URLs
still works, obviously).
If-Match relies on ETag, which depends on the Content-Encoding,
which is more fragile given we updated the etag on save, while normal
files are served by nginx. So this may occurs false mismatch.
There is a situation where the ETag can be generated by Nginx,
but then used by Django: when the user starts editing a layer,
the js client will send the ETag received from Nginx to uMap
as value to check is there is an editing conflict.
The overflow hidden removed in 72f8fd971d did cut of iframes and their content. However, it did introduce a scrollbar when the iframe is too big. Which is fixed here by adding a max-width of 100%.
There was a max-width but one with fixed pixel values before, which was removed in 345283782c (diff-5470058378896897263b7a99e4226772660e09d5e9e51b530fffc6075b8e07bfL1299).
The stylesheet-style's max-width will overwrite any width-specification given via the width-attribute on the iframe as well as width-conditions set as inline-styles. However, adding a inline max-width-style will overwrite the css-file specification due to higher css specificity.
The overflow that was removed in 72f8fd971d did cut off long URLs and such which where now visible overflowing the popup content. However, we do want the visible but using `break-word`.
Whenever the key or value is too long, the table was pushed being wider than the given container. And the overflow rules cut off the content of the table.
Fixes
- Remove overflow rules (reset to defaults, which is `auto`), which makes a scroll bar show up if content is too wide
- Let long text break in lines instead of pushing the table (which in turn prevents the scroll bar from showing up)
