fix#2280
That's a first step, which:
- internalize Formbuilder as a bunch of modules
- use Javascript classes instead of Leaflet ones
- remove dependencies to Leaflet (L.DomUtil…)
- replaces `L.FormBuilder` by `Form` (in theory generic, but not quite)
and `U.FormBuilder` by `MutatingForm` (knows about isDirty,
`inheritable` and such)
There is much more room for refactor, but let's do it step by step!
fix#2268
There is a tricky choice to do: the delete actually occurs in two
times, first the datalayer is hidden from the UI and set as "deleted"
(this can then be undone) then at next "save" it will totally removed.
When syncing, given we removed the "reset/undo" feature for now, and
because it was simpler, I decide to do both step in once.
When working on a proper "undo/redo", we may challenge this choice
again.
fix#2268
There is a tricky choice to do: the delete actually occurs in two
times, first the datalayer is hidden from the UI and set as "deleted"
(this can then be undone) then at next "save" it will totally removed.
When syncing, given we removed the "reset/undo" feature for now, and
because it was simpler, I decide to do both step in once.
When working on a proper "undo/redo", we may challenge this choice
again.
We now set the "closeRequested" on the receiver itself, otherwise there
is a race condition between the reconnect (which create a new transport)
and the onclose checking closeRequest on an old transport.
We now save the "closeRequested" on the receiver itself, other wise
there is a race condition between the reconnect (which create a new
transport) and the onclose checking closeRequest on an old transport.
Bumps
[pymdown-extensions](https://github.com/facelessuser/pymdown-extensions)
from 10.12 to 10.13.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a
href="https://github.com/facelessuser/pymdown-extensions/releases">pymdown-extensions's
releases</a>.</em></p>
<blockquote>
<h2>10.13</h2>
<ul>
<li><strong>NEW</strong>: Snippets: Allow multiple line numbers or line
number blocks separated by <code>,</code>.</li>
<li><strong>NEW</strong>: Snippets: Allow using a negative index for
number start indexes and end indexes. Negative indexes are converted to
positive indexes based on the number of lines in the snippet.</li>
<li><strong>FIX</strong>: Snippets: Properly capture empty newline at
end of file.</li>
<li><strong>FIX</strong>: Snippets: Fix issue where when non sections of
files are included, section labels are not stripped.</li>
<li><strong>FIX</strong>: BetterEm: Fixes for complex cases.</li>
<li><strong>FIX</strong>: Blocks: More consistent handling of empty
newlines in block processor extensions.</li>
</ul>
</blockquote>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a
href="36858c6b85"><code>36858c6</code></a>
Mention negative indexing in Snippets documentation</li>
<li><a
href="271950fb0d"><code>271950f</code></a>
More consistent newline handling in blocks extensions (<a
href="https://redirect.github.com/facelessuser/pymdown-extensions/issues/2553">#2553</a>)</li>
<li><a
href="9e26f64ee5"><code>9e26f64</code></a>
Allow negative indexes (<a
href="https://redirect.github.com/facelessuser/pymdown-extensions/issues/2552">#2552</a>)</li>
<li><a
href="1789d6094e"><code>1789d60</code></a>
Docs: Update JS deps</li>
<li><a
href="55ccf795df"><code>55ccf79</code></a>
Allow specifying multiple line selection blocks (<a
href="https://redirect.github.com/facelessuser/pymdown-extensions/issues/2551">#2551</a>)</li>
<li><a
href="f6102ac0dc"><code>f6102ac</code></a>
Fix some complex cases in BetterEm (<a
href="https://redirect.github.com/facelessuser/pymdown-extensions/issues/2547">#2547</a>)</li>
<li><a
href="9df48dbc84"><code>9df48db</code></a>
Strip sections from included file (<a
href="https://redirect.github.com/facelessuser/pymdown-extensions/issues/2541">#2541</a>)</li>
<li><a
href="377e8ff46d"><code>377e8ff</code></a>
Correctly document StripHTML defaults (<a
href="https://redirect.github.com/facelessuser/pymdown-extensions/issues/2535">#2535</a>)</li>
<li><a
href="68c70f9d12"><code>68c70f9</code></a>
Fix broken link to options in block-caption plugin page (<a
href="https://redirect.github.com/facelessuser/pymdown-extensions/issues/2533">#2533</a>)</li>
<li>See full diff in <a
href="https://github.com/facelessuser/pymdown-extensions/compare/10.12...10.13">compare
view</a></li>
</ul>
</details>
<br />
[](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)
Dependabot will resolve any conflicts with this PR as long as you don't
alter it yourself. You can also trigger a rebase manually by commenting
`@dependabot rebase`.
[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)
---
<details>
<summary>Dependabot commands and options</summary>
<br />
You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits
that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after
your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge
and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot close` will close this PR and stop Dependabot recreating
it. You can achieve the same result by closing it manually
- `@dependabot show <dependency name> ignore conditions` will show all
of the ignore conditions of the specified dependency
- `@dependabot ignore this major version` will close this PR and stop
Dependabot creating any more for this major version (unless you reopen
the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop
Dependabot creating any more for this minor version (unless you reopen
the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop
Dependabot creating any more for this dependency (unless you reopen the
PR or upgrade to it yourself)
</details>
