fix: error after deleting a path that was previously moved (#2479 )

When moving a path, this will put a once time listener on "moveend". If we delete this feature, and move the map, we should not execute the event callback. A better fix would be to cancel the event listener on delete, but that is much more work given how we deal with Leaflet events right now.
fix: error after deleting a path that was previously moved
2025-05-19 20:20:33 +02:00 · 2025-02-04 18:00:09 +01:00 · 2025-02-04 17:40:49 +01:00 · 2025-02-04 16:55:57 +01:00 · 2025-02-04 15:38:50 +00:00 · 2025-02-04 16:38:24 +01:00
6 changed files with 16 additions and 10 deletions
--- a/docs-users/requirements.txt
+++ b/docs-users/requirements.txt
@ -1,5 +1,5 @@
 # Force rtfd to use a recent version of mkdocs
 mkdocs==1.6.1
-pymdown-extensions==10.14.1
+pymdown-extensions==10.14.3
 mkdocs-material==9.5.50
-mkdocs-static-i18n==1.2.3
+mkdocs-static-i18n==1.3.0
--- a/docs/requirements.txt
+++ b/docs/requirements.txt
@ -1,5 +1,5 @@
 # Force rtfd to use a recent version of mkdocs
 mkdocs==1.6.1
-pymdown-extensions==10.14.1
+pymdown-extensions==10.14.3
 mkdocs-material==9.5.50
-mkdocs-static-i18n==1.2.3
+mkdocs-static-i18n==1.3.0
--- a/pyproject.toml
+++ b/pyproject.toml
@ -48,18 +48,18 @@ dev = [
  "djlint==1.36.4",
  "mkdocs==1.6.1",
  "mkdocs-material==9.5.50",
-  "mkdocs-static-i18n==1.2.3",
+  "mkdocs-static-i18n==1.3.0",
  "vermin==1.6.0",
-  "pymdown-extensions==10.14.1",
-  "isort==5.13.2",
+  "pymdown-extensions==10.14.3",
+  "isort==6.0.0",
 ]
 test = [
  "daphne==4.1.2",
-  "factory-boy==3.3.1",
+  "factory-boy==3.3.3",
  "playwright>=1.39",
  "pytest==8.3.4",
  "pytest-django==4.9.0",
-  "pytest-playwright==0.6.2",
+  "pytest-playwright==0.7.0",
  "pytest-rerunfailures==15.0",
  "pytest-xdist>=3.5.0,<4",
  "moto[s3]==5.0.27"
--- a/umap/static/umap/css/form.css
+++ b/umap/static/umap/css/form.css
@ -87,6 +87,7 @@ input[type="submit"] {
    border: none;
    text-decoration: none;
    background-color: white;
+    justify-content: center;
 }
 .dark .button,
 .dark [type="button"] {
--- a/umap/static/umap/js/modules/rendering/ui.js
+++ b/umap/static/umap/js/modules/rendering/ui.js
@ -267,6 +267,8 @@ const PathMixin = {
  },

  makeGeometryEditable: function () {
+    // Feature has been removed since then?
+    if (!this._map) return
    if (this._map._umap.editedFeature !== this.feature) {
      this.disableEdit()
      return
--- a/umap/utils.py
+++ b/umap/utils.py
@ -27,7 +27,10 @@ def _urls_for_js():
    Return templated URLs prepared for javascript.
    """
    urls = {}
-    for module in ["umap.urls", "umap.sync.app"]:
+    modules = ["umap.urls"]
+    if settings.WEBSOCKET_ENABLED:
+        modules.append("umap.sync.app")
+    for module in modules:
        names = _get_url_names(module)
        urls.update(
            dict(zip(names, [get_uri_template(url, module=module) for url in names]))
Author	SHA1	Message	Date
Yohan Boniface	b35740b029	fix: error after deleting a path that was previously moved (#2479 ) Some checks are pending Test & Docs / tests (postgresql, 3.12) (push) Waiting to run Details Test & Docs / lint (push) Waiting to run Details Test & Docs / docs (push) Waiting to run Details Test & Docs / tests (postgresql, 3.10) (push) Waiting to run Details When moving a path, this will put a once time listener on "moveend". If we delete this feature, and move the map, we should not execute the event callback. A better fix would be to cancel the event listener on delete, but that is much more work given how we deal with Leaflet events right now.	2025-02-04 18:00:09 +01:00
Yohan Boniface	c985cb3de5	fix: error after deleting a path that was previously moved When moving a path, this will put a once time listener on "moveend". If we delete this feature, and move the map, we should not execute the event callback. A better fix would be to cancel the event listener on delete, but that is much more work given how we deal with Leaflet events right now.	2025-02-04 17:40:49 +01:00
Yohan Boniface	4a82f587fa	chore: bump isort from 5.13.2 to 6.0.0 (#2472 )	2025-02-04 16:55:57 +01:00
dependabot[bot]	ed9ae0590b	chore: bump isort from 5.13.2 to 6.0.0 Bumps [isort](https://github.com/pycqa/isort) from 5.13.2 to 6.0.0. - [Release notes](https://github.com/pycqa/isort/releases) - [Changelog](https://github.com/PyCQA/isort/blob/main/CHANGELOG.md) - [Commits](https://github.com/pycqa/isort/compare/5.13.2...6.0.0) --- updated-dependencies: - dependency-name: isort dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>	2025-02-04 15:38:50 +00:00
Yohan Boniface	a48513fcd7	chore: make redis python dep optional (#2470 )	2025-02-04 16:38:24 +01:00
Yohan Boniface	4da5d2682a	chore: bump pymdown-extensions from 10.14.1 to 10.14.3 (#2474 )	2025-02-04 16:37:45 +01:00
dependabot[bot]	22293c8a44	chore: bump pymdown-extensions from 10.14.1 to 10.14.3 Bumps [pymdown-extensions](https://github.com/facelessuser/pymdown-extensions) from 10.14.1 to 10.14.3. - [Release notes](https://github.com/facelessuser/pymdown-extensions/releases) - [Commits](https://github.com/facelessuser/pymdown-extensions/compare/10.14.1...10.14.3) --- updated-dependencies: - dependency-name: pymdown-extensions dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>	2025-02-04 15:26:06 +00:00
Yohan Boniface	0dee5b1a3a	chore: bump mkdocs-static-i18n from 1.2.3 to 1.3.0 (#2475 )	2025-02-04 16:24:44 +01:00
Yohan Boniface	97dadf0101	chore: bump pytest-playwright from 0.6.2 to 0.7.0 (#2473 )	2025-02-04 16:24:07 +01:00
Yohan Boniface	22ca072364	chore: bump factory-boy from 3.3.1 to 3.3.3 (#2476 )	2025-02-04 16:23:11 +01:00
Yohan Boniface	17be255ed6	fix: center "Plus" button (#2477 ) Before: ![image](https://github.com/user-attachments/assets/916c6fc1-188c-442b-b364-772191531eed) After: ![image](https://github.com/user-attachments/assets/8b07b624-b1d2-40fe-b940-20ec51cfa050)	2025-02-04 16:02:20 +01:00
Yohan Boniface	9606bd864b	fix: center "Plus" button	2025-02-04 11:45:28 +01:00
dependabot[bot]	9b29a2efde	chore: bump factory-boy from 3.3.1 to 3.3.3 Bumps [factory-boy](https://github.com/FactoryBoy/factory_boy) from 3.3.1 to 3.3.3. - [Changelog](https://github.com/FactoryBoy/factory_boy/blob/master/docs/changelog.rst) - [Commits](https://github.com/FactoryBoy/factory_boy/compare/3.3.1...3.3.3) --- updated-dependencies: - dependency-name: factory-boy dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>	2025-02-03 17:18:19 +00:00
dependabot[bot]	7d1e5c676c	chore: bump mkdocs-static-i18n from 1.2.3 to 1.3.0 Bumps [mkdocs-static-i18n](https://github.com/ultrabug/mkdocs-static-i18n) from 1.2.3 to 1.3.0. - [Changelog](https://github.com/ultrabug/mkdocs-static-i18n/blob/main/docs/changelog.md) - [Commits](https://github.com/ultrabug/mkdocs-static-i18n/compare/1.2.3...1.3.0) --- updated-dependencies: - dependency-name: mkdocs-static-i18n dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>	2025-02-03 17:18:16 +00:00
dependabot[bot]	d024a22328	chore: bump pytest-playwright from 0.6.2 to 0.7.0 Bumps [pytest-playwright](https://github.com/microsoft/playwright-pytest) from 0.6.2 to 0.7.0. - [Release notes](https://github.com/microsoft/playwright-pytest/releases) - [Commits](https://github.com/microsoft/playwright-pytest/compare/v0.6.2...v0.7.0) --- updated-dependencies: - dependency-name: pytest-playwright dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>	2025-02-03 17:18:06 +00:00
Yohan Boniface	545770dfb9	chore: make redis python dep optional	2025-01-31 18:55:55 +01:00