almet/argos
1
0
Fork 0
mirror of https://framagit.org/framasoft/framaspace/argos.git synced 2025-04-28 09:52:38 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions

🐛 — Fix bug in retry_before_notification logic when success

Browse source
This commit is contained in:
Luc Didry 2025-01-26 07:54:31 +01:00
parent 797a60a85c
commit 2b82f7c8f2
No known key found for this signature in database
GPG key ID: EA868E12D0257E3C
2 changed files with 4 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
CHANGELOG.md
View file

@ -2,6 +2,8 @@
## [Unreleased] ## [Unreleased]
🐛 — Fix bug in retry_before_notification logic when success
## 0.7.2 ## 0.7.2
Date: 2025-01-24 Date: 2025-01-24

4
argos/server/alerting.py
View file

@ -36,7 +36,7 @@ def need_alert(
# create notification of success immediately # create notification of success immediately
if ( if (
status == "success" status == "success"
and task.contiguous_failures >= task.retry_before_notification and task.contiguous_failures >= task.retry_before_notification + 1
): ):
send_notif = True send_notif = True
task.contiguous_failures = 0 task.contiguous_failures = 0
@ -56,7 +56,7 @@ def need_alert(
task.contiguous_failures = task.retry_before_notification task.contiguous_failures = task.retry_before_notification
# Severity has not changed, but there has been enough failures # Severity has not changed, but there has been enough failures
# to create a notification # to create a notification
elif task.retry_before_notification + 1 == task.contiguous_failures: elif task.contiguous_failures == task.retry_before_notification + 1:
send_notif = True send_notif = True
return send_notif return send_notif