* Support WTForms 3
* default value to None for WTForm backward compatibility
* switch back to empty string as default
WTForm backward compatibility needs that
* format
* get weight sum along with bills to scale
otherwise, we need to get the weight sum for each displayed bill.
Here, we are much more scalable
* add test
* format
* remove unused import
* oops, restore pagination to 100
* add comments
* format
* rename method to make it clearer
And also, make it static, since it doesn't rely on instance.
* improve comments and naming
* improve naming
* missing article
* Change the way we import datetime
This makes it easier to use datetime.date later.
* Display monthly statistics for the range of months where the project was active
Currently, we display a hard-coded "one year" range of monthly statistics
starting from today. This generally is not the intended behaviour: for
instance, on an archived project, the bills might all be older than one
year, so the table only displays months without any operation.
Instead, display all months between the first and last bills. There might
be empty months in the middle, but that's intended, because we want all
months to be consecutive.
If there are no bills, simply display an empty table.
Co-authored-by: Baptiste Jonglez <git@bitsofnetworks.org>
* Translated using Weblate (German)
Currently translated at 100.0% (265 of 265 strings)
Co-authored-by: Jannik Lang <jannik.lang@posteo.de>
Translate-URL: https://hosted.weblate.org/projects/i-hate-money/i-hate-money/de/
Translation: I Hate Money/I Hate Money
* Translated using Weblate (German)
Currently translated at 100.0% (265 of 265 strings)
Co-authored-by: Christian H <sunrisechain@gmail.com>
Translate-URL: https://hosted.weblate.org/projects/i-hate-money/i-hate-money/de/
Translation: I Hate Money/I Hate Money
* Translated using Weblate (German)
Currently translated at 100.0% (265 of 265 strings)
Co-authored-by: Jannik Lang <jannik.lang@posteo.de>
Translate-URL: https://hosted.weblate.org/projects/i-hate-money/i-hate-money/de/
Translation: I Hate Money/I Hate Money
Co-authored-by: Jannik Lang <jannik.lang@posteo.de>
Co-authored-by: Christian H <sunrisechain@gmail.com>
* Translated using Weblate (French)
Currently translated at 100.0% (265 of 265 strings)
Co-authored-by: Alexis Metaireau <alexis@notmyidea.org>
Translate-URL: https://hosted.weblate.org/projects/i-hate-money/i-hate-money/fr/
Translation: I Hate Money/I Hate Money
* Translated using Weblate (Italian)
Currently translated at 75.0% (199 of 265 strings)
Co-authored-by: Paolo Campetto <fbok61hw@anonaddy.me>
Translate-URL: https://hosted.weblate.org/projects/i-hate-money/i-hate-money/it/
Translation: I Hate Money/I Hate Money
Co-authored-by: Alexis Metaireau <alexis@notmyidea.org>
Co-authored-by: Paolo Campetto <fbok61hw@anonaddy.me>
* /healthcheck endpoint usefull for monitoring, ci test also uses this
* customizable PORT with environment variable
* customizable PUID/PGID, reduce attack surface and allow better integration in rootless environments
* size optimization
* update to python 3.10
* add postgresql compatibility
* PUID/PGID default as root to not break current user environments
* Do not require a captcha when using the API
This was trickier than expected, due to some side effects : when the
captcha is set to `True` via configuration, it doesn't change the
behavior directly of the ProjectForm class, but does so only when the
project form is used in the `web.py` module.
So, when just using the API (and not using the web.py module, for
instance during tests — manual or functional), no problem was shown,
and everything was working properly.
But at soon as somebody sees the "/" endpoint, the captcha was
required, by both the API and the `web.py` module.
This fixes it by adding a way to bypass the captcha with a new
`bypass_captcha` property on the form.
Prior to this commit, things were done by activating or deactivating a
"captcha" property on the class on-the-fly, which caused side-effects.
This is now using subclasses, which makes the code simpler to
understand, and less prone to side-effects.
Thanks @zorun for the idea.
Currently translated at 95.0% (252 of 265 strings)
Co-authored-by: whenwesober <naomi16i_1298q@cikuh.com>
Translate-URL: https://hosted.weblate.org/projects/i-hate-money/i-hate-money/id/
Translation: I Hate Money/I Hate Money
Co-authored-by: whenwesober <naomi16i_1298q@cikuh.com>
Currently translated at 100.0% (265 of 265 strings)
Co-authored-by: Oğuz Ersen <oguzersen@protonmail.com>
Translate-URL: https://hosted.weblate.org/projects/i-hate-money/i-hate-money/tr/
Translation: I Hate Money/I Hate Money
Co-authored-by: Oğuz Ersen <oguzersen@protonmail.com>
* Fixes#896
sidebar_table_layout switches to flex column layout
remove all 'float' buttons, replace them with nice flexboxes.
bill_table needs a flex-basis because with a very small width, it has a 0 height. I don't really know why, but adding a flex-basis: auto shows it.
* ensure new bill is on top of pagination
Currently translated at 100.0% (264 of 264 strings)
Co-authored-by: Glandos <bugs-github@antipoul.fr>
Translate-URL: https://hosted.weblate.org/projects/i-hate-money/i-hate-money/fr/
Translation: I Hate Money/I Hate Money
Co-authored-by: Glandos <bugs-github@antipoul.fr>
Fixes#875
Original showcase images are kept in another directory, and compressed
in webp in the distributed directory.
Since they won't change so much, let's keep them in git.
The style for top and bottom pagination was different, and the top part
was confusing.
Also translate bottom pagination text.
Co-authored-by: Baptiste Jonglez <git@bitsofnetworks.org>
* Update changelog.
Based on the work done in #570 and #834 by @Natim and @Glandos.
* Update contributing.rst release instructions.
* Update documentation configuration.
* Update translations
* Update translation strings
* Preparing release 5.0.0
* Back to development: 5.0.1
Currently translated at 26.9% (71 of 263 strings)
Co-authored-by: a-g-rao <athrigrao@gmail.com>
Translate-URL: https://hosted.weblate.org/projects/i-hate-money/i-hate-money/kn/
Translation: I Hate Money/I Hate Money
Co-authored-by: a-g-rao <athrigrao@gmail.com>
* Make multiple currency optional
Fixes#848
A description is provided in project settings to make the feature self explanatory.
* I forgot the description.
Let's update translation altogether.
* black format
* Translated using Weblate (Turkish)
Currently translated at 100.0% (262 of 262 strings)
Co-authored-by: Oğuz Ersen <oguzersen@protonmail.com>
Translate-URL: https://hosted.weblate.org/projects/i-hate-money/i-hate-money/tr/
Translation: I Hate Money/I Hate Money
* Translated using Weblate (Kannada)
Currently translated at 22.8% (60 of 263 strings)
Co-authored-by: a-g-rao <athrigrao@gmail.com>
Translate-URL: https://hosted.weblate.org/projects/i-hate-money/i-hate-money/kn/
Translation: I Hate Money/I Hate Money
Co-authored-by: Oğuz Ersen <oguzersen@protonmail.com>
Co-authored-by: a-g-rao <athrigrao@gmail.com>
Currently translated at 18.9% (49 of 258 strings)
Co-authored-by: a-g-rao <athrigrao@gmail.com>
Translate-URL: https://hosted.weblate.org/projects/i-hate-money/i-hate-money/kn/
Translation: I Hate Money/I Hate Money
Co-authored-by: a-g-rao <athrigrao@gmail.com>
The new support for currency broke backwards compatibility on the API:
$ curl -X POST $URL/api/projects -d 'name=yay&id=yay&password=yay&contact_email=yay@notmyidea.org'
{"default_currency": ["This field is required."]}
This is a case we were not testing (will be fixed in subsequent commits)
To fix this, simply set default_currency to XXX by default.
Fix#780
This a breaking change, the API for authentication is different, as it now requires `project_id`. Token is generated with only the project_id (so it's shorter than before), and signature is done by mixing password with secret key. Thus, it expires on every project code change.
This mock was already applied to all tests, because it was done statically
in the TestCurrencyConverter class definition. But it was really not
clear that it's applied everywhere.
Moving this to the setUp() function makes it much clearer.
Also, remove useless redefinition in other tests.
Fix#803
On some systems, there is no configured local timezone, so LOCALTZ is
a fallback object, that don't fit use case for flask-babel.
Detect this and use 'UTC' instead
Currently, we don't display the current language in the list. This is
confusing because the list changes when switching language.
Now we always display the full list, and we highlight the current
language.
* add the event listener only once, instead of every time the form is clicked
* use a standard button by default, so that the second state with a
"danger" button is more visible
* reset confirmation button to original state when losing focus
Co-authored-by: Glandos <bugs-github@antipoul.fr>
This is the same idea as deleting a project: deleting history is also a
major destructive action. We reuse the same form as for project deletion
to ask for the private code and provide CSRF validation.
Most of the tests are using a separate database, but we have a few tests
that are loading default values and are writing to /tmp/ihatemoney.db.
This is annoying because it's also the database used for development:
running the test suite breaks the dev database.
To fix this, always use a separate testing database to avoid interference.
The previous query was working fine on sqlite and mariadb, but not on
postgresql :
return self.get_bills_unordered().group_by(Bill.original_currency).count() > 1
psycopg2.errors.GroupingError: column "bill.id" must appear in the GROUP BY clause or be used in an aggregate function
The failing SQL query was:
[SQL: SELECT count(*) AS count_1
FROM (SELECT bill.id AS bill_id, ...
FROM bill JOIN person ON person.id = bill.payer_id JOIN project ON project.id = person.project_id
WHERE bill.payer_id = person.id AND person.project_id = project.id AND project.id = %(id_1)s GROUP BY bill.original_currency) AS anon_1]
The problem is that sqlalchemy creates a subquery for postgresql, and the
internal query does not make sense.
GROUP BY is not actually useful, we simply need to count the number of
distinct currencies in the list of bills.
Currently, the private code is mandatory in the edit form, and it's not
clear whether it's meant to **check** for the right private code or to
**change** the private code.
Make the field optional and rename the help message to make it clearer
it's only meant to **change** the private code.
Also change the field type to "password" instead of simple string.
Co-authored-by: Alexis Métaireau <alexis@notmyidea.org>
Currency switching is both simpler and less powerful. This was done primarily for users, to have a clear and logical understanding, but the code is also simpler. The main change is that it is now forbidden to switch a project to "no currency" if bills don't share the same currency.
Also, tests assume that projects are created without currency, as in the web UI.
Currently translated at 100.0% (231 of 231 strings)
Translated using Weblate (Esperanto)
Currently translated at 94.8% (219 of 231 strings)
Translated using Weblate (Esperanto)
Currently translated at 92.6% (214 of 231 strings)
Co-authored-by: phlostically <phlostically@mailinator.com>
Translate-URL: https://hosted.weblate.org/projects/i-hate-money/i-hate-money/eo/
Translation: I Hate Money/I Hate Money
Currently translated at 55.8% (129 of 231 strings)
Translated using Weblate (Greek)
Currently translated at 42.8% (99 of 231 strings)
Translated using Weblate (Greek)
Currently translated at 26.4% (61 of 231 strings)
Co-authored-by: Eugenia Russell <eugenia.russell2019@gmail.com>
Translate-URL: https://hosted.weblate.org/projects/i-hate-money/i-hate-money/el/
Translation: I Hate Money/I Hate Money
Currently translated at 24.6% (57 of 231 strings)
Translated using Weblate (Greek)
Currently translated at 20.7% (48 of 231 strings)
Co-authored-by: Eugenia Russell <eugenia.russell2019@gmail.com>
Translate-URL: https://hosted.weblate.org/projects/i-hate-money/i-hate-money/el/
Translation: I Hate Money/I Hate Money
Currently translated at 91.3% (211 of 231 strings)
Translated using Weblate (Dutch)
Currently translated at 80.0% (185 of 231 strings)
Co-authored-by: Rens <hallo@rensoliemans.nl>
Translate-URL: https://hosted.weblate.org/projects/i-hate-money/i-hate-money/nl/
Translation: I Hate Money/I Hate Money
Currently translated at 78.3% (181 of 231 strings)
Translated using Weblate (Dutch)
Currently translated at 77.4% (179 of 231 strings)
Co-authored-by: Rens <hallo@rensoliemans.nl>
Translate-URL: https://hosted.weblate.org/projects/i-hate-money/i-hate-money/nl/
Translation: I Hate Money/I Hate Money
Currently translated at 78.3% (181 of 231 strings)
Translated using Weblate (Dutch)
Currently translated at 77.4% (179 of 231 strings)
Co-authored-by: Sander Kooijmans <weblate@gogognome.nl>
Translate-URL: https://hosted.weblate.org/projects/i-hate-money/i-hate-money/nl/
Translation: I Hate Money/I Hate Money
By formatting datetime on the server, we get nice localized datetime
strings that are adapted to the currently-selected language. Example:
- English: "Apr 26, 2020, 3:58:54 PM"
- French: "26 avr. 2020 à 15:58:54"
- German: "26.04.2020, 15:58:54"
- Spanish: "26 abr. 2020 15:58:54"
- Indonesian: "26 Apr 2020 15.58.54"
- Chinese: "2020年4月26日 下午3:58:54"
However, there is a downside: time is not adapted to the user timezone.
The solution is to define a timezone on the server: we use the server OS
timezone by default, and it can be customized through the
BABEL_DEFAULT_TIMEZONE setting. It's still not ideal, because it assumes
that all users are in the same timezone (the one configured on the server).
Currently translated at 100.0% (231 of 231 strings)
Translated using Weblate (Japanese)
Currently translated at 77.9% (180 of 231 strings)
Co-authored-by: Jwen921 <yangjingwen0921@gmail.com>
Translate-URL: https://hosted.weblate.org/projects/i-hate-money/i-hate-money/ja/
Translation: I Hate Money/I Hate Money
* Translated using Weblate (German)
Currently translated at 100.0% (231 of 231 strings)
Co-authored-by: mdmdmdmdmd <exe_tmp@gmx.de>
Translate-URL: https://hosted.weblate.org/projects/i-hate-money/i-hate-money/de/
Translation: I Hate Money/I Hate Money
* Translated using Weblate (Japanese)
Currently translated at 15.5% (36 of 231 strings)
Co-authored-by: Jwen921 <yangjingwen0921@gmail.com>
Translate-URL: https://hosted.weblate.org/projects/i-hate-money/i-hate-money/ja/
Translation: I Hate Money/I Hate Money
Co-authored-by: mdmdmdmdmd <exe_tmp@gmx.de>
Co-authored-by: Jwen921 <yangjingwen0921@gmail.com>
Currently translated at 1.7% (4 of 231 strings)
Added translation using Weblate (Swedish)
Co-authored-by: Kristoffer Grundström <swedishsailfishosuser@tutanota.com>
Translate-URL: https://hosted.weblate.org/projects/i-hate-money/i-hate-money/sv/
Translation: I Hate Money/I Hate Money
